PING: Reviewer needed - patch which fixes class SunToolkit for IcedTea6-1.8 and IcedTea6-1.9

[Dr Andrew John Hughes]

On 09:29 Tue 12 Apr     , Pavel Tisnovsky wrote:
> 
> 
> -------- Original Message --------
> Subject: Reviewer needed - patch which fixes class SunToolkit for
> IcedTea6-1.8	and IcedTea6-1.9
> Date: Thu, 31 Mar 2011 13:55:23 +0200
> From: Pavel Tisnovsky <ptisnovs at redhat.com>
> To: IcedTea <distro-pkg-dev at openjdk.java.net>
> 
> Hi all,
> 
> I addition to my previous mail, I'd also like to backport SunToolkit
> patch to IcedTea6-1.8 and IcedTea6-1.9. Diffs generated against recent
> IcedTea6-1.8 and IcedTea6-1.9 are stored in attachments.
> 
> Please note, that the patch itself is a bit different from patch used in
> IcedTea6-1.10 and IcedTea6 HEAD due to different lines being patched.
> 

That's why it's a good idea to post the specific patch being applied as
there will be changes when backporting.

Here, there is a mistake; the NEWS item is being wrongly filed under Plugin
in both patches.  It should be placed under 'Backports' as in HEAD and 1.10.

> ChangeLog entry is the same:
> 2011-03-31  Pavel Tisnovsky  <ptisnovs at redhat.com>
> 
>     * Makefile.am: Add new patch.
>     * NEWS: Updated (added info about new fix).
>     * patches/mark_sun_toolkit_privileged_code.patch:
>     Patch which fixes the AccessControlException while
>     working with Color class in a PropertyEditor
> 
> 
> Can anybody please review it?
> 
> Cheers
> Pavel
> 

> diff -r c4b749a83103 Makefile.am
> --- a/Makefile.am	Fri Mar 25 15:36:46 2011 -0400
> +++ b/Makefile.am	Thu Mar 31 13:25:26 2011 +0200
> @@ -377,7 +377,8 @@
>  	patches/latent_jaxp_bug.patch \
>  	patches/openjdk/6675802-securityExceptions-applets.patch \
>  	patches/openjdk/6691503-malicious-applet-always-on-top.patch \
> -	patches/jtreg-LastErrorString.patch
> +	patches/jtreg-LastErrorString.patch \
> +	patches/mark_sun_toolkit_privileged_code.patch
>  
>  if WITH_ALT_HSBUILD
>  ICEDTEA_PATCHES += patches/hotspot/$(HSBUILD)/openjdk-6886353-ignore_deoptimizealot.patch \
> diff -r c4b749a83103 NEWS
> --- a/NEWS	Fri Mar 25 15:36:46 2011 -0400
> +++ b/NEWS	Thu Mar 31 13:25:26 2011 +0200
> @@ -16,6 +16,7 @@
>    - PR632: patches/security/20110215/6878713.patch breaks shark zero build
>  * Plugin
>    - PR542: Plugin fails with NPE on http://www.openprocessing.org/visuals/iframe.php?visualID=2615
> +  - Fixed AccessControlContext which was thrown while working with Color class in a PropertyEditor
>  
>  New in release 1.8.7 (2011-02-15):
>  
> diff -r c4b749a83103 patches/mark_sun_toolkit_privileged_code.patch
> --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
> +++ b/patches/mark_sun_toolkit_privileged_code.patch	Thu Mar 31 13:25:26 2011 +0200
> @@ -0,0 +1,12 @@
> +--- openjdk/jdk/src/share/classes/sun/awt/SunToolkit.orig.java	2011-03-11 10:48:29.000000000 +0100
> ++++ openjdk/jdk/src/share/classes/sun/awt/SunToolkit.java	2011-03-11 11:24:33.000000000 +0100
> +@@ -70,8 +70,7 @@
> +
> +     /* Load debug settings for native code */
> +     static {
> +-        String nativeDebug = System.getProperty("sun.awt.nativedebug");
> +-        if ("true".equalsIgnoreCase(nativeDebug)) {
> ++        if (AccessController.doPrivileged(new GetBooleanAction("sun.awt.nativedebug"))) {
> +             DebugSettings.init();
> +         }
> +     };
> 

> diff -r e4336b504f8a Makefile.am
> --- a/Makefile.am	Fri Mar 25 15:04:00 2011 -0400
> +++ b/Makefile.am	Thu Mar 31 13:26:40 2011 +0200
> @@ -340,7 +340,8 @@
>  	patches/latent_jaxp_bug.patch \
>  	patches/openjdk/6675802-securityExceptions-applets.patch \
>  	patches/openjdk/6691503-malicious-applet-always-on-top.patch \
> -	patches/jtreg-LastErrorString.patch
> +	patches/jtreg-LastErrorString.patch \
> +	patches/mark_sun_toolkit_privileged_code.patch
>  
>  if WITH_ALT_HSBUILD
>  ICEDTEA_PATCHES += \
> diff -r e4336b504f8a NEWS
> --- a/NEWS	Fri Mar 25 15:04:00 2011 -0400
> +++ b/NEWS	Thu Mar 31 13:26:40 2011 +0200
> @@ -16,6 +16,7 @@
>    - S6980392, PR642: simple correction in testcase, added missing bracket
>  * Plugin
>    - PR542: Plugin fails with NPE on http://www.openprocessing.org/visuals/iframe.php?visualID=2615
> +  - Fixed AccessControlContext which was thrown while working with Color class in a PropertyEditor
>  
>  New in release 1.9.7 (2011-02-15):
>  
> diff -r e4336b504f8a patches/mark_sun_toolkit_privileged_code.patch
> --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
> +++ b/patches/mark_sun_toolkit_privileged_code.patch	Thu Mar 31 13:26:40 2011 +0200
> @@ -0,0 +1,12 @@
> +--- openjdk/jdk/src/share/classes/sun/awt/SunToolkit.orig.java	2011-03-11 10:48:29.000000000 +0100
> ++++ openjdk/jdk/src/share/classes/sun/awt/SunToolkit.java	2011-03-11 11:24:33.000000000 +0100
> +@@ -70,8 +70,7 @@
> +
> +     /* Load debug settings for native code */
> +     static {
> +-        String nativeDebug = System.getProperty("sun.awt.nativedebug");
> +-        if ("true".equalsIgnoreCase(nativeDebug)) {
> ++        if (AccessController.doPrivileged(new GetBooleanAction("sun.awt.nativedebug"))) {
> +             DebugSettings.init();
> +         }
> +     };
> 


-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37