RFC: PR698 Shark failes to find LLVM 2.9 System headers during build

[Xerxes Rånby]

On 2011-04-12 14:20, Gary Benson wrote:
> Hi Xerxes,
>
> The patches look good to me.  Would you be able to submit them
> upstream too?  I can walk you through the process if you like.
>
> Thanks,
> Gary
Thanks,
I want to submit this patch upstream.
I do like to get advise on how to push this through the OpenJDK upstream process.
I have filed the SCA.

On 2011-04-12 14:27, Dr Andrew John Hughes wrote:
> On 13:16 Tue 12 Apr     , Xerxes Rånby wrote:
>> In LLVM 2.9
>> llvm/System/Threading.h and llvm/System/Host.h
>> have been moved to
>> llvm/Support/Threading.h and llvm/Support/Host.h
>>
>> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=689
>>
>> The attached patches use SHARK_LLVM_VERSION to include Support/*.h for LLVM 2.9
>> and later and still includes System/*.h for older LLVM releases.
>>
>> Ok to commit all attached patches to:
>> Icedtea6-1.9 ?
>>
>> Icedtea6-1.10 ?
>>
>> Icedtea6 trunk?
>>
> There is a typo in NEWS: failes -> fails.
Thank you! I have now fixed this.

> I'm also getting question marks in your surname in the ChangeLog.
I think my email client have picked the wrong mime type for the attachments
Content-Type: text/x-patch;
The patch itself contains UTF-8. if my client would have added the attachment as
Content-Type: text/x-patch; charset=UTF-8;
then I think my surname would have looked ok inside your client.
My surname looks ok with an "å" If I download the attachment and then view it using gedit/vi etc...

> Otherwise, the change looks good for all three branches.
>
> Why not 1.8 too?
There was quite a lot of Shark fixes between 1.8 and 1.9.
1.9 Contains the first Shark release that passed the TCK.

1.8 Contains the working ARM Thumb2 JIT that will break if I back-port all the Shark fixes that went into 1.9.

I have pushed to:
http://icedtea.classpath.org/hg/release/icedtea6-1.9/rev/495cac553ab0
http://icedtea.classpath.org/hg/release/icedtea6-1.10/rev/b142e8e007e6
http://icedtea.classpath.org/hg/icedtea6/rev/307d19e0cca0

ps. my surname looks ok if i view the Changelog after checking out the sources instead of using the web-frontend.

Cheers
Xerxes