[RFC][plugin]: fix concurrency problems in PAV.java

[Andrew Su]

----- Original Message -----
> Hi.
> 
> I found a few problems in PluginAppletViewer.java.
> We were modifying/reading from two static hash maps
> concurrently. The hash maps were "applets" and "status".
> status was only modified in a synchronized method,
> but we were reading from it outside of that method and
> that's unsafe.
> 
> As far as I can tell, there are no group of operations
> that need to happen atomically, so using ConcurrentHashMaps
> should be enough.
> 
> I've also done a bit of refactoring (removing dead code,
> adding some SuppressWarnings annotations, making members
> private, etc).
> 
> Any criticism is appreciated.
> 

Hi Denis,

I think the clean-up should go in its own patch.

Seems like an extra space @

@@ -1645,7 +1587,8 @@
 
         new Thread(new Runnable()
          {
-             public void run()
+             @SuppressWarnings("deprecation")
+            public void run()
              {
                  ClassLoader cl = p.applet.getClass().getClassLoader();

Cheers,
  Andrew