Fwd: Re: adding testng after removig of junit

[Jiri Vanek]

-------- Original Message --------
Subject: Re: adding testng after removig of junit
Date: Tue, 12 Apr 2011 16:17:28 +0200
From: Jiri Vanek <jvanek at redhat.com>
To: distro-pkg-dev at openjdk.java.net

On 04/12/2011 03:01 PM, Dr Andrew John Hughes wrote:
> On 14:43 Tue 12 Apr     , Jiri Vanek wrote:
>> On 04/12/2011 02:33 PM, Dr Andrew John Hughes wrote:
>>> On 13:02 Tue 12 Apr     , Pavel Tisnovsky wrote:
>>>> Hi all,
>>>>
>>>> as a person who is going to regularly run the IcedTea-web tests (I'd
>>>> also like to add new test cases in the near future) I'd prefer if he
>>>> really began to use TestNG.
>>>>
>>>
>>> Why?
>>>
>>> (BTW, I think you want 'it' not 'he' if I'm reading the above correctly
>>> and you're referring to IcedTea-Web)
>>>
>>>> Cheers
>>>> Pavel
>>>>
>>>>
>>>>
>>
>> Why? It is simple. And I wrote it many times - testng have much better
>> output then junit. So it is with configuration.  Why are you ignoring my
>> posts?! Why have you not defend YOUR solution? I posted reasons to
>> switch to testng. You make me no reply except ignoring me.
>>
>
> I already did.  We had an extensive discussion on this during the patch
> development.  Please read the archives.  I'm not going to waste time
> repeating myself.

I read it deeply. Don't worry. I just had late reaction:-/ (my fault-but
it  was just a day after commit).
>
> In brief:
>
> * With the current solution, we can directly produce the JTreg-like
> output we want via our subclass and already do.  From what I
> understand of the TestNG patch, it would produce XML and then we'd
> have to convert it.  Exactly why is that better?

Because we DO NOT want jtreg like result. Pavel is doing magic to create
reports as are now from such a bad output. From xml - we have all
informations. Pavel will use it to produce reports containing stack
traces, will be able to see directly which ones should fail and which
should pass. Will be able to separate groups,Will be able to create very
solid statistics, and whatever we can imagine. It is pitty to lost all
the information. jtreg-like is just poor summary - and without ant it is
probably impossible to reach something better.

Another advance is extreme configurability (see bottom).


>
> * Switching to TestNG also adds a mass of dependencies which aren't
> needed with JUnit, making it harder for people to run the test suite.
>

testng are three jars. Junit is one jar. I do not see difference whether
wee need to make special steps to add one jar to classpath or three. Al
four of them are easily to be found and downloaded. And all are packaged
in fedora (an in most of distros).

> Unless you can produce a clear example of why switching to TestNG
> for IcedTea-Web is essential and which overrides the need for all
> those additional dependencies, I see no reason to drop a solution that
> works and has already been extensively reviewed.
>

What I see essential is output of test framework and configureability.
junit is not about to be run from commadline. It is ant tool. And we do
not want ant for sure (we have make).
You will probably never use or run this test. Me, Pavel and Omair will
do it most of time. And for myself i really wont to configure what i'm
running. This Luncher class and makefile "send all classes to classpath"
is dreadfull hack.

Btw.. I have already posted all of those dis/advantages;)
>> J.
>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: tests-output.tar.gz
Type: application/x-gzip
Size: 11234 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110412/f93fd2c7/tests-output.tar.gz