[RFC][plugin]: fix concurrency problems in PAV.java

[Denis Lila]

> while (!applets.containsKey(identifier) && // Map is populated only by
> reFrame
> (wait < maxWait)) {
> 
> try {
> Thread.sleep(50);
> wait += 50;
> } catch (InterruptedException ie) {
> // just wait
> }
> }
> 
> Surely this should be a timed wait and additions to applets should be
> accompanied by
> a notifyAll?

That's what I thought when I first saw this code. But this works, and I
see no practical reason to change it. If you really think we should, I
could do it, but it should be it's own changeset.

> PluginAppletViewer oldFrame = applets.get(identifier);
> 
> // We should not try to destroy an applet during
> // initialization. It may cause an inconsistent state,
> // which would bad if it's a trusted applet that
> // read/writes to files
> waitForAppletInit((NetxPanel) applets.get(identifier).panel);
> 
> The two get calls could retrieve different values if a put occurs in
> the interim.

Yes, but it doesn't matter. oldFrame is dead code.

> The cast to AppletPanel is redundant.

The enumeration is not using generics, so we need the cast.


> Indentation change. Shouldn't be in this patch.
...<snip>...
> This looks like just brackets being added. Shouldn't be in this patch.

The indentation changed because the code was wrapped in
a synchronized block. Not putting it in this patch would be
breaking style conventions.

> To be frank, this class is a mess.

I couldn't agree more.
And it's not just this class. It's almost every class in the
icedtea-web sun.applet package.

As for the points you made that I didn't reply to:
None of them were pointing out any mistakes in my patch,
so can I push this patch, and address some of them
(in particular the comments on destroyApplet) in my second
patch (the refactoring one)?

Thank you,
Denis.

----- Original Message -----
> On 15:23 Tue 12 Apr , Denis Lila wrote:
> 
> snip...
> 
>
snip...