[icedtea-web] RFC: Switch to explicit locks and condition queues in PAV

Deepak Bhole dbhole at redhat.com
Fri Apr 15 07:43:40 PDT 2011


* Dr Andrew John Hughes <ahughes at redhat.com> [2011-04-14 18:44]:
> This is the change I mentioned in the previous discussion.  It replaces
> the use of CHM monitors with explicit locks and condition queues.  It also
> simplifies (I hope) the panel lock case by using an explicit lock and
> condition queue rather than a mix of the panel object and sleep.

Er, forgot to talk about the patch... I see no issues. The concern Denis
pointed out will cause spurious wake ups, but there are conditional
checks around waitTillTimeout to ensure that the code goes back to
sleep so it should be fine given the expected frequency of such events.

Cheers,
Deepak



More information about the distro-pkg-dev mailing list