[icedtea-web] RFC: Patches to make the plugin work with Midori

[Omair Majid]

On 04/15/2011 06:58 PM, Deepak Bhole wrote:
>
> * Deepak Bhole<dbhole at redhat.com>  [2011-04-15 18:57]:
>> >  Midori currently segfaults with the icedtea-web plugin in F15[1]. Attached
>> >  (first) patch fixes the issue.
>> >
>> >  I discovered an additional issue later related to applet sizing (that I
>> >  have seen only with Midori so far). Attached (second) patch fixes that
>> >  issue. The comments in the patch explain why the change is needed.
>> >
>> >  1:https://bugzilla.redhat.com/show_bug.cgi?id=691259
>> >
>> >  ChangeLogs:
>> >  2011-04-15  Deepak Bhole<dbhole at redhat.com>
>> >
>> >       RH691259: Midori sends a SIGSEGV with the IcedTea NP Plugin
>> >       * plugin/icedteanp/IcedTeaNPPlugin.cc (NP_Initialize): Rather than
>> >       returning immediately if already initialized, return after function tables
>> >       are reset.
>> >
>> >  2011-04-15  Deepak Bhole<dbhole at redhat.com>
>> >
>> >       * plugin/icedteanp/java/sun/applet/PluginAppletViewer.java
>> >       (PluginAppletPanelFactory::createPanel): Make the NetxPanel variable
>> >       final. Resize frame to work around problem whereby AppletViewerPanel
>> >       doesn't always set the right size initially.
>> >
>> >
>> >  Okay for 1.0 (F15 has 1.0.x) and HEAD?
>> >

Both patches look good to me.

Cheers,
Omair