[icedtea-web] RFC: Do not show prompts on exceptions for the plugin

[Deepak Bhole]

* Omair Majid <omajid at redhat.com> [2011-04-20 12:10]:
> Hi,
> 
> If the plugin fails to load because of exceptions, the exceptions
> should be indicated by the applet loading screen. Showing users
> error dialog for applets not working does not seem too nice. But
> since applet loading/splash screens are not implemented, the
> attached patch disables the error message and makes the exceptions
> log to stdout/stderr.
> 
> ChangeLog:
> 2011-04-20  Omair Majid  <omajid at redhat.com>
> 
>   * plugin/icedteanp/java/sun/applet/PluginAppletSecurityContext.java
>   (PluginAppletSecurityContext): Set the launch handler to the
>   stdout/stderr based one.
> 
> Any thoughts or suggestions?
> 

Looks fine to me. OK for head.

Cheers,
Deepak

> Cheers,
> Omair

> diff -r 211a5e73d119 plugin/icedteanp/java/sun/applet/PluginAppletSecurityContext.java
> --- a/plugin/icedteanp/java/sun/applet/PluginAppletSecurityContext.java	Mon Apr 18 17:38:31 2011 -0400
> +++ b/plugin/icedteanp/java/sun/applet/PluginAppletSecurityContext.java	Wed Apr 20 12:02:49 2011 -0400
> @@ -58,6 +58,7 @@
>  import java.util.Map;
>  
>  import net.sourceforge.jnlp.runtime.JNLPRuntime;
> +import net.sourceforge.jnlp.DefaultLaunchHandler;
>  import netscape.javascript.JSObjectCreatePermission;
>  
>  class Signature {
> @@ -242,6 +243,7 @@
>          // that JNLPRuntime will try to install
>          if (System.getSecurityManager() == null) {
>              JNLPRuntime.initialize(/* isApplication */false);
> +            JNLPRuntime.setDefaultLaunchHandler(new DefaultLaunchHandler());
>          }
>  
>          JNLPRuntime.disableExit();