[icedtea-web] RFC: Use non-blocking NPN_GetURLNotify

[Deepak Bhole]

This one didn't appear in my inbox :/ re-sending...

* Deepak Bhole <dbhole at redhat.com> [2011-04-20 15:36]:
> Hi,
> 
> Attached patch mitigates the issue mentioned here:
> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2011-April/013706.html
> 
> This patch uses a non-blocking function to get the URL. We discard the
> eventual notification, but that is no different that what we do right now
> (we just print it currently and ignore it). For that matter, there isn't
> really much we _can_ do in case of load failure anyway..
> 
> ChangeLog:
> 2011-04-20  Deepak Bhole <dbhole at redhat.com>
> 
>     * plugin/icedteanp/IcedTeaNPPlugin.cc (consume_message): Use
>     NPN_GetURLNotify (non-blocking) instead of NPN_GetURL (blocking) so that
>     the plugin is free to process additional requests.
> 
> Okay for HEAD and 1.0?
> 
> Cheers,
> Deepak

> diff -r ad820e40fe56 plugin/icedteanp/IcedTeaNPPlugin.cc
> --- a/plugin/icedteanp/IcedTeaNPPlugin.cc	Wed Apr 20 15:02:56 2011 -0400
> +++ b/plugin/icedteanp/IcedTeaNPPlugin.cc	Wed Apr 20 15:26:03 2011 -0400
> @@ -1179,7 +1179,7 @@
>            PLUGIN_DEBUG ("plugin_in_pipe_callback: URL target %s\n", parts[4]);
>  
>            NPError np_error =
> -            (*browser_functions.geturl) (data->owner, decoded_url, parts[4]);
> +            (*browser_functions.geturlnotify) (data->owner, decoded_url, parts[4], NULL);
>  
>  
>            if (np_error != NPERR_NO_ERROR)