[icedtea-web] RFC: Use non-blocking NPN_GetURLNotify

Deepak Bhole dbhole at redhat.com
Thu Apr 21 08:04:20 PDT 2011


* Omair Majid <omajid at redhat.com> [2011-04-21 10:57]:
> On 04/20/2011 04:08 PM, Deepak Bhole wrote:
> >This one didn't appear in my inbox :/ re-sending...
> >
> >* Deepak Bhole<dbhole at redhat.com>  [2011-04-20 15:36]:
> >>Hi,
> >>
> >>Attached patch mitigates the issue mentioned here:
> >>http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2011-April/013706.html
> >>
> >>This patch uses a non-blocking function to get the URL. We discard the
> >>eventual notification, but that is no different that what we do right now
> >>(we just print it currently and ignore it). For that matter, there isn't
> >>really much we _can_ do in case of load failure anyway..
> >>
> >>ChangeLog:
> >>2011-04-20  Deepak Bhole<dbhole at redhat.com>
> >>
> >>     * plugin/icedteanp/IcedTeaNPPlugin.cc (consume_message): Use
> >>     NPN_GetURLNotify (non-blocking) instead of NPN_GetURL (blocking) so that
> >>     the plugin is free to process additional requests.
> >>
> >>Okay for HEAD and 1.0?
> 
> Looks good to me.
> 

Thanks!

Cheers,
Deepak

> Cheers,
> Omair



More information about the distro-pkg-dev mailing list