RFC: drop bytebuffer-compact patch from icedtea6

Omair Majid omajid at redhat.com
Thu Apr 21 08:47:45 PDT 2011


Hi,

The bytebuffer-compact patch in icedtea6 was meant to address PR60. This 
bug was fixed independently in openjdk6  as 6593946: (bf) 
X-Buffer.compact() does not discard mark as specified. Since the fix was 
applied upstream, the icedtea patch was modified so it did not conflict 
with upstream.

The openjdk6 fix introduces a new method discardMark() in 
java.nio.Buffer, which is simply "mark = -1". The icedtea6 patch (as it 
stands currently) introduces a new method clearMark() (in addition to 
the discardMark() which is used elsewhere in the jdk) which does the 
exact same thing, and then replaces all uses of "mark = -1" in 
java.nio.Buffer class with clearMark(). IMHO, this patch is useless and 
should be dropped.

The IcedTea7 version of the patch can also be dropped, but at least that 
just replaces "mark = -1" with discardMark() and does not introduce any 
new methods.

Any thoughts or concerns?

ChangeLog
2011-04-21  Omair Majid  <omajid at redhat.com>

   * Makefile.am (ICEDTEA_PATCHES): Drop bytebuffer-compact.patch
   * patches/bytebuffer-compact.patch: Remove useless patch.

Cheers,
Omair
-------------- next part --------------
A non-text attachment was scrubbed...
Name: icedtea6-remove-bytebuffer-patch.patch
Type: text/x-patch
Size: 2147 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110421/5dd308f1/icedtea6-remove-bytebuffer-patch.patch 


More information about the distro-pkg-dev mailing list