RFC: remove unneeded parts of the lcms patch in icedtea6

Omair Majid omajid at redhat.com
Thu Apr 21 12:24:04 PDT 2011


Hi,

The attached patch removes redundant parts of the lcms patch 
(patches/lcms.patch) in icedtea6. These parts are performing null checks 
which are not needed. In the case of the first chunk, the null check is 
redundant (a check is performed a few lines before). The second chunk is 
just a stylistic change, from (!var) to (var == null). The third chunk 
is also redundant as a null pointer would have caused issues before 
getting to that line.

Okay to commit?

ChangeLog:
2011-04-21  Omair Majid  <omajid at redhat.com>

   * patches/lcms.patch: Remove useless chunks in the patch.

Cheers,
Omair
-------------- next part --------------
A non-text attachment was scrubbed...
Name: icedtea6-remove-redundant-lcms-chunks.patch
Type: text/x-patch
Size: 1677 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110421/5290de49/icedtea6-remove-redundant-lcms-chunks.patch 


More information about the distro-pkg-dev mailing list