RFC: drop bytebuffer-compact patch from icedtea6

[Omair Majid]

On 04/21/2011 05:51 PM, Dr Andrew John Hughes wrote:
> On 12:13 Thu 21 Apr     , Omair Majid wrote:
>>> On 04/21/2011 11:47 AM, Omair Majid wrote:
>>>>> Hi,
>>>>>
>>>>> The bytebuffer-compact patch in icedtea6 was meant to address
>>>>> PR60. This bug was fixed independently in openjdk6 as
>>>>> 6593946: (bf) X-Buffer.compact() does not discard mark as
>>>>> specified. Since the fix was applied upstream, the icedtea
>>>>> patch was modified so it did not conflict with upstream.
>>>>>
>>>>> The openjdk6 fix introduces a new method discardMark() in
>>>>> java.nio.Buffer, which is simply "mark = -1". The icedtea6
>>>>> patch (as it stands currently) introduces a new method
>>>>> clearMark() (in addition to the discardMark() which is used
>>>>> elsewhere in the jdk) which does the exact same thing, and
>>>>> then replaces all uses of "mark = -1" in java.nio.Buffer
>>>>> class with clearMark(). IMHO, this patch is useless and
>>>>> should be dropped.
>>>>>
>>>>> The IcedTea7 version of the patch can also be dropped, but at
>>>>> least that just replaces "mark = -1" with discardMark() and
>>>>> does not introduce any new methods.
>>>>>
>>>>> Any thoughts or concerns?
>>>>>
>>>>>
>>>
>>> I didnt get this email back, so I suppose others might not have
>>> received it either. Apologies if you have already seen it.
>>>
> No, this is the first time I saw this e-mail.
>
> The patch was previously discussed
> here:http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2009-April/005352.html
>
>

Yes, I saw that link, but I dont think we reached a conclusion there
about whether to drop the patch or not.

> I'm for dumping it from both 6 and 7.
>

Done. I have dropped it from both.

> Please updatehttp://icedtea.classpath.org/wiki/IcedTea_JDK6_Patches
> to say it has been dropped too.
>

Done, I think. I didnt add it in any "Made obsolete by OpenJDK6..." 
section. Should I do that?

> We probably need to clone and edit that page for 7 too.  The 6 one
> also needs updating.
>

I am going through the icedtea6 patches right now to forward port/drop 
them. Once I am done, I will try and create a page for 7.

Cheers,
Omair