[RFC][plugin]: Class loading problem.

[Omair Majid]

On 04/29/2011 04:14 PM, Denis Lila wrote:
>> If it's a warning and it bothers you, I think we should fix the cause
>> (thought that should be a separate patch), not merely suppress the
>> warning.
>
> Ok. Although, I don't think we should "fix" it. Doing that would
> involve inserting a serialVersionUID field, which we only need
> if we wanted to serialize NetxPanel (which we don't). The
> compiler generates one itself, so even if we were doing
> serialization we might not need to introduce that field.
> Not to mention that putting in that field even though we don't
> serialize might confuse future readers.
>

Well, I am just objecting to the SupressWarning. If you think it should 
never be serialized, perhaps overriding writeObject and readObject and 
throwing NotSerializableException might be better - though it sounds 
like overkill to me.

>
>> No, I think it's fine for now. AFAIK, knowing the name of the thread
>> group is not sufficient to create other threads in it. As long as
>> other applets cant access/use these other threadgroups, we are fine.
>
> Hm... other applets can access these thread groups, but only if
> they have the same uKey, and hence share a classloader. Is that ok?
>

Yeah, that's fine. They are after all, sharing classloaders.

The patch looks fine to me.

Cheers,
Omair