[ahughes at redhat.com: Re: Fwd: Re: [RFC] - extended creation of simple reproducers jars]

[Jiri Vanek]

On 08/01/2011 04:00 PM, Dr Andrew John Hughes wrote:
> You seem to have only posted this to me, so the reply didn't go out either...

YY. Sorry. Your approve have been lost in list:-/

Thanx J.

>
> ----- Forwarded message from Dr Andrew John Hughes<ahughes at redhat.com>  -----
>
> Date: Mon, 1 Aug 2011 14:59:57 +0100
> From: Dr Andrew John Hughes<ahughes at redhat.com>
> To: Jiri Vanek<jvanek at redhat.com>
> Subject: Re: Fwd: Re: [RFC] - extended creation of simple reproducers jars
> User-Agent: Mutt/1.5.21 (2010-09-15)
>
> On 13:13 Mon 01 Aug     , Jiri Vanek wrote:
>> ping :)
>>
>> -------- Original Message --------
>> Subject: Re: [RFC] - extended creation of simple reproducers jars
>> Date: Tue, 26 Jul 2011 12:49:04 +0200
>> From: Jiri Vanek<jvanek at redhat.com>
>> To: IcedTea Distro List<distro-pkg-dev at openjdk.java.net>,        Dr Andrew John Hughes<ahughes at redhat.com>
>>
>> On 07/25/2011 03:56 PM, Dr Andrew John Hughes wrote:
>>> On 07:19 Wed 20 Jul     , Jiri Vanek wrote:
>>>>
>>>
>>> snip...
>>>
>>>>
>>>> I think that I'm following the rest of icedtea-web styl. I'm creating file with list of reproduces in one step, and then compiling and jarring them in second. Please note, that there is much more reproducers then files in each of one of them.
>>>
>>> IcedTea-Web uses multiple rules.  This is all in one rule.
>>
>> Hm... So you are  not ok with situation that all directories  which will be proceeded are listed in  junit-jnlp-dist-dirs.txt - generated by rule before , and then that files are proceeded in runtime cycle?
>> What is your counsel here? I have an opinion to generate for each of the line (directory) in  junit-jnlp-dist-dirs.txt file NAME_java.txt  and NAME_notjava.txt which will contains its java/nonJava files. But this will generate quite a lot small files (each wich 1-5 lines).
>> I still considersolution below as more user-friendly.
>>
>
> Ok, let's go with what you have here, and then we can consider it in more detail once it's in.
>
>> Thanx for any advice, J.
>>
>>>
>>>>>
>>>>> diff -r 4267bb156f08 Makefile.am
>>>>> --- a/Makefile.am	Tue Jul 19 12:14:35 2011 -0400
>>>>> +++ b/Makefile.am	Tue Jul 19 19:16:19 2011 +0200
>>>>> @@ -465,11 +465,18 @@
>>>>>     stamps/netx-dist-tests-prepare-reproducers.stamp: junit-jnlp-dist-dirs.txt
>>>>>     	simpleReproducers=(`cat $(abs_top_builddir)/junit-jnlp-dist-dirs.txt `); \
>>>> ^^ list gathered in previous step
>>>>>     	for dir in "$${simpleReproducers[@]}" ; do \
>>>> traversing through this list
>>>>> +	  echo "processing: $$dir" ; \
>>>>>     	  mkdir -p $(JNLP_TESTS_DIR)/$$dir ; \
>>>>> -	  $(BOOT_DIR)/bin/javac -d  $(JNLP_TESTS_DIR)/$$dir/  $(JNLP_TESTS_SRCDIR)/simple/$$dir/srcs/* ; \
>>>>>     	  d=`pwd` ; \
>>>>> +	  cd $(JNLP_TESTS_SRCDIR)/simple/$$dir/srcs/ ; \
>>>>> +	  srcFiles=`find . -mindepth 1 -type f -name "*.java" | sed "s/.\/*//"` ; \
>>>> finding java files of this reproducer
>>>>> +	  notSrcFiles=`find . -mindepth 1 -type f \! -name "*.java" | sed "s/.\/*//"` ; \
>>>> finding non-java files of this reproducer
>>>>> +	  $(BOOT_DIR)/bin/javac -d  $(JNLP_TESTS_DIR)/$$dir/  $$srcFiles ; \
>>>> all java files of this reproducer compiled
>>>>> +	  if [ -n "$$notSrcFiles" ] ; then \
>>>>> +	    cp -R --parents $$notSrcFiles $(JNLP_TESTS_DIR)/$$dir/ ; \
>>>> all non src files of reproducer copied.
>>>>> +	  fi ; \
>>>>>     	  cd $(JNLP_TESTS_DIR)/$$dir/ ; \
>>>>> -	    $(BOOT_DIR)/bin/jar cf $(JNLP_TESTS_SERVER_DEPLOYDIR)/$$dir.jar * ; \
>>>>> +	  $(BOOT_DIR)/bin/jar cf $(JNLP_TESTS_SERVER_DEPLOYDIR)/$$dir.jar * ; \
>>>> final jar constructed from classes and  copied files.
>>>>>     	cd $$d ; \
>>>>>     	  cp -R $(JNLP_TESTS_SRCDIR)/simple/$$dir/resources/*  $(JNLP_TESTS_SERVER_DEPLOYDIR)/ ; \
>>>>>     	done ; \
>>>>> diff -r 4267bb156f08 tests/jnlp_tests/README
>>>>> --- a/tests/jnlp_tests/README	Tue Jul 19 12:14:35 2011 -0400
>>>>> +++ b/tests/jnlp_tests/README	Tue Jul 19 19:16:19 2011 +0200
>>>>> @@ -1,1 +1,2 @@
>>>>> -Each file in directory simple must follows naming convention and is compiled/jared automatically into server's working directory and content of resources likewise. The name of jnlp is independent, and there can be even more jnlps for each future jar.  Files in advanced directory have to care about themselves, but even those can have some parts inside simple directory, so some parts of them are processed automatically.  There are three reproducers – simpletest1, simpletest2 and deadlocktest, which tests test’s suite itself and serve as examples of behaviour.
>>>>> +Each file in directory simple must follows naming convention and is compiled/jared automatically into server's working directory and content of resources likewise. The name of jnlp is independent, and there can be even more jnlps for each future jar.  Directories should be honored in srcs and in resources, but noty in testcases.
>>>>> +Files in advanced directory have to care about themselves, but even those can have some parts inside simple directory, so some parts of them are processed automatically.  There are three reproducers – simpletest1, simpletest2 and deadlocktest, which tests test’s suite itself and serve as examples of behaviour.
>>>>
>>>
>>
>