[RFC] changes to CommitPolicy

Saad Mohammad smohammad at redhat.com
Thu Aug 4 07:16:54 PDT 2011

On 08/04/2011 09:58 AM, Jiri Vanek wrote:
> On 08/04/2011 03:55 PM, Saad Mohammad wrote:
>> [. . .]
>> On 08/04/2011 09:39 AM, Deepak Bhole wrote:
>>> "IcedTea-Web code changes/new feature should be accompanied with
>>> > >appropriate tests. If no tests are added/modified, changes should be
>>> > >accompanied with an explanation as to why."
>> Hi,
>> Where would we store our explanation if no tests are accompanied with 
>> the new changes?
> I think that write them to the email with review  request is enough. 
> Altho I think write them into changelog is vaste of space. What is 
> your opinion?
Oh, I was thinking we had to keep record in a separate file in 
icedtea-web. Which may not be the best solution. :\
But, I do agree with you. I think writing them on the email is a much 
better way. Reviewers can validate if a test is required or not (if 
test(s) are not provided).
I also agree with you about writing them to a changelog; it would be a 
waste of space.

>> Also, can IcedTea-Web run all tests automatically after they are 
>> added to the test directory? Or would the programmer need to modify 
>> the makefile.am every time a new test is added?
>> [. . .]
> Most of the reproducers should be enough when added into directory 
> (.../icedtea-web/tests/jnlp_tests/simple  - see also readme), but some 
> cases maybe will need their own build infrastructure. (or maybe 
> extending current one).

Okay :).

> Regards J.

Saad Mohammad

More information about the distro-pkg-dev mailing list