[icedtea-web] RFC: Minor buildfix for 1.0

[Xerxes Rånby]

On 2011-08-05 13:25, Mark Wielaard wrote:
> On Fri, 2011-08-05 at 06:51 -0400, Omair Majid wrote:
>> On 08/05/2011 06:10 AM, Mark Wielaard wrote:
>>>
>>> Doh, I hadn't noticed that. I have installed junit 3.8.2-4 on it now.
>>> Lets see what the next build says.
>>>
>> Do you think it might be worth it to have ./configure fail if junit is
>> not found?
>
> No, that would be annoying for someone not interested in the tests
> (yeah, everybody should always run all tests, but...)
>
>> Also, I don't think junit 3 will suffice, icedtea-web uses
>> classes from the org.junit package.
>
> Aha, I see there is also a different package junit4 (how confusing, are
> they binary incompatible?). Installed junit4_4.8.2-2 too now on the
> x86_64 build slave (which is running Debian 6.0.2 aka Squeeze BTW).
>
> Cheers,
>
> Mark

Thanks,

I rebuilt the last icedtea-web checking on the x86_64 builder
Now it did find the junit4 jar but ... something are still FUBAR..
http://builder.classpath.org/icedtea/buildbot/builders/icedtea-web-squeeze-x86_64/builds/147

The armv5 builder are also running squeeze. I am puzzled why your x86_64 squeeze builder 
fail while the armv5 squeeze builder pass...

I notice that your x86_64 builder are using a rather old bootstrap compiler that 
internally includes the old icedtea-np plugin code:
java version "1.6.0_18"
OpenJDK Runtime Environment (IcedTea6 1.8.7) (6b18-1.8.7-2~squeeze1)
OpenJDK 64-Bit Server VM (build 14.0-b16, mixed mode)

This might be the issue.

I have actually manually replaced the bootstrap compiler on the armv5 builder to something 
more recent.
java version "1.6.0_22"
OpenJDK Runtime Environment (IcedTea6 1.10.1) (6b22-1.10.1-0ubuntu1)
JamVM (build 1.6.0-devel+ladybug, inline-threaded interpreter with stack-caching)

I have simply rebuilt a somewhat more recent icedtea src-deb from the ubuntu archive to 
test using jamvm's self-host capabilities on the armv5 builder. I think that my change 
switching the bootstrap compiler from icedtea6 1.8 to icedtea6 1.10 on the armv5 builder 
might be the root cause why your x86_64 builder fail and why my armv5 builder pass.

see: 
http://builder.classpath.org/icedtea/buildbot/builders/icedtea-web-squeeze-x86_64/builds/147/steps/jtregcheck/logs/stdio

30 of the new junit tests failed,
one did almost succeed

FAILED: testTemplateCDATA(net.sourceforge.jnlp.JNLPMatcherTest) tried to access class 
net.sourceforge.jnlp.Node from class net.sourceforge.jnlp.JNLPMatcher
FAILED: testTemplateDuplicate(net.sourceforge.jnlp.JNLPMatcherTest) net/sourceforge/jnlp/Node
FAILED: testTemplateWildCharsRandom(net.sourceforge.jnlp.JNLPMatcherTest) 
net/sourceforge/jnlp/Node
FAILED: testTemplateDifferentOrder(net.sourceforge.jnlp.JNLPMatcherTest) 
net/sourceforge/jnlp/Node
FAILED: testTemplateWildCharsAsAllValues(net.sourceforge.jnlp.JNLPMatcherTest) 
net/sourceforge/jnlp/Node
FAILED: testTemplateComments(net.sourceforge.jnlp.JNLPMatcherTest) net/sourceforge/jnlp/Node
FAILED: testTemplateDifferentValues(net.sourceforge.jnlp.JNLPMatcherTest) 
net/sourceforge/jnlp/Node
FAILED: testTemplateExtraChild(net.sourceforge.jnlp.JNLPMatcherTest) net/sourceforge/jnlp/Node
FAILED: testTemplateFewerChild(net.sourceforge.jnlp.JNLPMatcherTest) net/sourceforge/jnlp/Node
FAILED: testTemplateDifferentFile(net.sourceforge.jnlp.JNLPMatcherTest) 
net/sourceforge/jnlp/Node
FAILED: testApplicationCDATA(net.sourceforge.jnlp.JNLPMatcherTest) net/sourceforge/jnlp/Node
FAILED: testApplicationDuplicate(net.sourceforge.jnlp.JNLPMatcherTest) 
net/sourceforge/jnlp/Node
FAILED: testApplicationDifferentOrder(net.sourceforge.jnlp.JNLPMatcherTest) 
net/sourceforge/jnlp/Node
FAILED: testApplicationComments(net.sourceforge.jnlp.JNLPMatcherTest) 
net/sourceforge/jnlp/Node
FAILED: testApplicationWildCharsRandom(net.sourceforge.jnlp.JNLPMatcherTest) 
net/sourceforge/jnlp/Node
FAILED: testApplicationDifferentCodebaseValue(net.sourceforge.jnlp.JNLPMatcherTest) 
net/sourceforge/jnlp/Node
FAILED: testApplicationExtraChild(net.sourceforge.jnlp.JNLPMatcherTest) 
net/sourceforge/jnlp/Node
FAILED: testApplicationFewerChild(net.sourceforge.jnlp.JNLPMatcherTest) 
net/sourceforge/jnlp/Node
FAILED: testApplicationDifferentFile(net.sourceforge.jnlp.JNLPMatcherTest) 
net/sourceforge/jnlp/Node
Passed: net.sourceforge.jnlp.JNLPMatcherTest.testNullJNLPFiles
FAILED: testCallingMatchMultiple(net.sourceforge.jnlp.JNLPMatcherTest) 
net/sourceforge/jnlp/Node
FAILED: net.sourceforge.jnlp.ParserBasic tried to access class net.sourceforge.jnlp.Parser 
from class net.sourceforge.jnlp.ParserBasic
FAILED: testUnsupportedSpecNumber(net.sourceforge.jnlp.ParserCornerCases) tried to access 
class net.sourceforge.jnlp.Parser from class net.sourceforge.jnlp.ParserCornerCases
FAILED: testApplicationAndComponent(net.sourceforge.jnlp.ParserCornerCases) 
net/sourceforge/jnlp/Parser
FAILED: testCommentInElements(net.sourceforge.jnlp.ParserCornerCases) 
net/sourceforge/jnlp/Parser
FAILED: testCommentInAttributes(net.sourceforge.jnlp.ParserCornerCases) 
net/sourceforge/jnlp/Parser
FAILED: testNestedComments(net.sourceforge.jnlp.ParserCornerCases) net/sourceforge/jnlp/Parser
FAILED: testMissingXmlDecleration(net.sourceforge.jnlp.ParserMalformedXml) tried to access 
class net.sourceforge.jnlp.Parser from class net.sourceforge.jnlp.ParserMalformedXml
FAILED: testMalformedArguments(net.sourceforge.jnlp.ParserMalformedXml) 
net/sourceforge/jnlp/Parser
FAILED: testTagNotClosed(net.sourceforge.jnlp.ParserMalformedXml) net/sourceforge/jnlp/Parser
FAILED: testUnquotedAttributes(net.sourceforge.jnlp.ParserMalformedXml) 
net/sourceforge/jnlp/Parser
Test results: passed: 0; failed: 30; ignored: 0

Cheers
Xerxes