[RFC] changes to CommitPolicy

[Deepak Bhole]

* Dr Andrew John Hughes <ahughes at redhat.com> [2011-08-04 21:54]:
> On 09:39 Thu 04 Aug     , Deepak Bhole wrote:
> > > >
> > > >I think it is slightly confusing. What are your thoughts about something
> > > >like:
> > > >
> > > >"IcedTea-Web code changes/new feature should be accompanied with
> > > >appropriate tests. If no tests are added/modified, changes should be
> > > >accompanied with an explanation as to why."
> > > >
> > 
> > Above sounds good to me!
> > 
> 
> "accompanied with" doesn't sound right to me.  And aren't 'new feature' (sic)
> code changes?
> 
> How about:
> 
> "IcedTea-Web code changes should be accompanied by appropriate regression tests.
> If this is not the case, a suitable explanation should be supplied."
> 

I never even thought of the with/by :) But any way, I am fine with the
above too.

Cheers,
Deepak

> > Cheers,
> > Deepak
> > 
> 
> -- 
> Andrew :)
> 
> Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
> 
> Support Free Java!
> Contribute to GNU Classpath and IcedTea
> http://www.gnu.org/software/classpath
> http://icedtea.classpath.org
> PGP Key: F5862A37 (https://keys.indymedia.org/)
> Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37