[icedtea-web] RFC: Minor buildfix for 1.0

Deepak Bhole dbhole at redhat.com
Fri Aug 5 08:14:22 PDT 2011


* Dr Andrew John Hughes <ahughes at redhat.com> [2011-08-04 21:47]:
> On 15:30 Thu 04 Aug     , Deepak Bhole wrote:
> > Hi,
> > 
> > Just tried to do a clean 1.0 build and noticed that it failed. Not sure how
> > this slipped before :/
> > 
> 
> That's worrying.  Do you not always do clean builds?  IcedTea-Web is tiny,
> so there's really no excuse.
> 

I do for all non-trivial changes. That is why I said I am not sure how
this was missed. I agree that it should've been spotted.

I am surprised (as Mark already mentioned) that the build-bot didn't
either... I didn't know it wasn't building all branches.

I'll commit this to 1.0.

Thanks,
Deepak

> > Attached patch fixes the debug() statement to match the signature
> > present in 1.0. 
> > 
> > Okay for 1.0?
> > 
> 
> Yes.
> 
> > 2011-08-04  Deepak Bhole <dbhole at redhat.com>
> > 
> >     * plugin/icedteanp/java/sun/applet/PluginStreamHandler.java
> >     (readPair): Fix call to PluginDebug.debug() to match signature.
> > 
> > Cheers,
> > Deepak
> 
> > diff -r 7ee2e487f4e2 plugin/icedteanp/java/sun/applet/PluginStreamHandler.java
> > --- a/plugin/icedteanp/java/sun/applet/PluginStreamHandler.java	Wed Aug 03 14:11:11 2011 -0400
> > +++ b/plugin/icedteanp/java/sun/applet/PluginStreamHandler.java	Thu Aug 04 15:28:04 2011 -0400
> > @@ -222,7 +222,7 @@
> >              }
> >          }
> >  
> > -        PluginDebug.debug("readPair: '", array[0], "' - '", array[1], "' ", end);
> > +        PluginDebug.debug("readPair: '" + array[0] + "' - '" + array[1] + "' " + end);
> >          return end;
> >      }
> >  
> 
> 
> -- 
> Andrew :)
> 
> Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
> 
> Support Free Java!
> Contribute to GNU Classpath and IcedTea
> http://www.gnu.org/software/classpath
> http://icedtea.classpath.org
> PGP Key: F5862A37 (https://keys.indymedia.org/)
> Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37



More information about the distro-pkg-dev mailing list