Reviewer needed: backport to IcedTea6 HEAD: "6806261: BigDecimal.longValueExact() method throws NullPointerException"

[Xerxes Rånby]

Hi Pavel!

Thank you for bakporting more tests!

fre 2011-08-12 klockan 14:56 +0200 skrev Pavel Tisnovsky:
> Greetings,
> 
> here's another fix I'd like to backport to IcedTea6 HEAD: "6806261:
> BigDecimal.longValueExact() method throws NullPointerException". This
> fix contains only new regression tests, which were checked on RHEL 5 x86_64.
> 
> ChangeLog entry:
> 
> 2011-08-12  Pavel Tisnovsky  <ptisnovs at redhat.com>
> 
>         * Makefile.am: added new patch
>         * NEWS: updated with backport
>         *
> patches/openjdk/6806261-BigDecimal_longValueExact_throws_NPE.patch:
>         Backport of 6806261: BigDecimal.longValueExact() method throws
>         NullPointerException
> 
> 
> Can anybody please review this backport?
> 
> Thank you in advance,
> Pavel

> diff -r 4c641e5e379d patches/openjdk/6806261-BigDecimal_longValueExact_throws_NPE.patch
> --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
> +++ b/patches/openjdk/6806261-BigDecimal_longValueExact_throws_NPE.patch	Fri Aug 12 14:53:46 2011 +0200
> @@ -0,0 +1,398 @@
> +# HG changeset patch
> +# User xlu
> +# Date 1243208132 25200
> +# Node ID 3994c5c669cbc5d8da999449bf702ce3588e7a3a
> +# Parent  8d2efec31d78546035943afd41f9bb07a89c7dca
> +6806261: BigDecimal.longValueExact() method throws NullPointerException
> +Summary: add various tests to test the change to 6622432
> +Reviewed-by: darcy
> +
> +diff -r 8d2efec31d78 -r 3994c5c669cb test/java/math/BigDecimal/EqualsTests.java
> +--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
> ++++ openjdk/jdk/test/java/math/BigDecimal/EqualsTests.java	Sun May 24 16:35:32 2009 -0700

> ++/*
> ++ * @test
> ++ * @bug 1234567
> ++ * @summary Test BigDecimal.equals() method.
> ++ * @author xlu
> ++ */

> +diff -r 8d2efec31d78 -r 3994c5c669cb test/java/math/BigDecimal/PrecisionTests.java
> +--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
> ++++ openjdk/jdk/test/java/math/BigDecimal/PrecisionTests.java	Sun May 24 16:35:32 2009 -0700

> ++ * @test
> ++ * @bug 1234567
> ++ * @summary Test that precision() is computed properly.
> ++ * @author Joseph D. Darcy
> ++ */
> ++

Why are the both tests @bug 1234567? i think changing the bug id to
6806261 would be better.

Since this backport only add more tests im all in favour for you to push
them.

Cheers
Xerxes