[RFC[PATCH]: Updated Patch for validating signedJNLP file at launch

[Saad Mohammad]

On 08/15/2011 12:51 PM, Omair Majid wrote:
> On 08/15/2011 12:04 PM, Saad Mohammad wrote:
>
[. . .]
>
>>>
>>> Also, is this behaviour (if the jar is signed but does not have a
>>> sigend jnlp file, then a warning is shown) documented somewhere? I ask
>>> because I find it rather strange. AFAIK, a lot of applications fit
>>> this pattern. I am not sure if showing warnings for all of these makes
>>> sense.
>>
>> Unfortunately, I did not find any documentations that state anything
>> about displaying a warning, but it's the way Oracle behave. I assume
>> IcedTea-web should behave similar?
>>
>> I have also noticed that Oracle only display the warning if the jar file
>> is not verified. If it's a verified jar, it does not show any warning
>> regarding a signed JNLP. I have not made that change with IcedTea-Web, I
>> was debating whether it should show this warning every time or not. I
>> think I will implement that on my updated patch.
>>
>
> Hm.. I tested Oracle's javaws with SweetHome3D and I got the warning 
> dialog, but I dont see any signed JNLP warnings with JPathReport:
>
> http://www.jgoodies.com/download/jpathreport/jpathreport.jnlp
>
> There might be a more specific condition to showing the warning than 
> just a missing signed jnlp file.

Yes, you are right. I have done a bit of digging and I figured out the 
warning is only shown when the <property> tag is used within resources.
(FYI, warning is not displayed if jvm arguments are passed through the 
JNLP file).

>
>>>> + private void checkForMain(List<JARDesc> jars) throws 
>>>> LaunchException {
>>>>
>>>> - activateJars(initialJars);
>>>> + ApplicationDesc ad = (ApplicationDesc) file.getLaunchInfo();
>>>> + String mainClass = ad.getMainClass();
>>>
>
> Hmm... I just realized that this may not work well at all. What if 
> file.getLaunchInfo() returns an AppletDesc?

Good catch. I will have to put an if statement to find out if it's an 
AppletDesc or an ApplicationDesc.
I will also look into removing static variables and removing 
JNLPClassLoader dependency like you have suggested.
Thanks.

[. . .]
> Cheers,
> Omair


-- 
Cheers,
Saad Mohammad