[RFC][IcedTea-Web] UI Update for SecurityDialog

[Danesh Dadachanji]

Hi,

The licensing of the icon from GNOME is under the GPL. Omair and I 
discussed the consequences of bringing this into IcedTea-Web. We decided 
it would be better/less work for me to make an icon, rather than finding 
one under the Creative Commons and attributing it correctly etc.

Here is a new patch. The code itself hasn't changed, I've just removed 
the crediting of GNOME in the comments and the changelog.

ChangeLog
+2011-08-11  Danesh Dadachanji <ddadacha at redhat.com>
+
+	Update UI for SecurityDialog
+	* netx/net/sourceforge/jnlp/resources/question.png: New icon added.
+	* netx/net/sourceforge/jnlp/security/CertWarningPane.java:
+	(addComponents): When certs are verified, question.png is used as the 
icon
+	and SAlwaysTrustPublisher is automatically selected.
+	* netx/net/sourceforge/jnlp/security/SecurityDialog.java:
+	(initDialog): Changed the title of a CERT_WARNING dialog.

Okay for head?

Regards,
Danesh

On 11/08/11 12:46 PM, Danesh Dadachanji wrote:
> Hi,
>
> I've pulled this code out of the patch for PR742 since it isn't directly
> related.
>
> To recap the changes in this email, when a cert is Verified, a new icon
> is shown and automatically selects the "Always Trust" checkbox when an
> applet is verified. Along the way I found a miscalculation in the window
> size of the dialog. It was too small to display the entire icon so I
> increased the height.
>
> Snippet from PR742 email[1]:
>
> On 10/08/11 06:01 PM, Deepak Bhole wrote:
>> When a cert has been verified and we show a prompt with the new question
>> icon, the title still says "Warning - Security" ... we should probably
>> update this to something that doesn't look as alarming ... maybe
>> "Security approval needed" or something?
>
> Changed the title to "Security Approval Required", "Required" was more
> consistent with what the other titles were.
>
> I also changed the message of when it is _not_ verified to "Security
> Warning", again to be more consistent. It was orignially "Warning -
> Security".
>
> ChangeLog
> +2011-08-11 Danesh Dadachanji <ddadacha at redhat.com>
> +
> + Update UI for SecurityDialog
> + * netx/net/sourceforge/jnlp/resources/question.png: New icon added.
> Credit
> + to The GNOME Project for the image.
> + * netx/net/sourceforge/jnlp/security/CertWarningPane.java:
> + (addComponents): When certs are verified, question.png is used as the
> icon
> + and SAlwaysTrustPublisher is automatically selected.
> + * netx/net/sourceforge/jnlp/security/SecurityDialog.java:
> + (initDialog): Changed the title of a CERT_WARNING dialog.
> +
>
> [1]
> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2011-August/015411.html
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: question.png
Type: image/png
Size: 2501 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110816/377bf463/question.png 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: UI-Update-for-SecurityDialog.patch
Type: text/x-patch
Size: 3687 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110816/377bf463/UI-Update-for-SecurityDialog.patch