[RFC[PATCH]: Updated Patch for validating signedJNLP file at launch
Saad Mohammad
smohammad at redhat.com
Mon Aug 22 11:58:41 PDT 2011
On 08/22/2011 02:37 PM, Omair Majid wrote:
> On 08/22/2011 12:25 PM, Saad Mohammad wrote:
>> Updated patch is attached.
>>
>
> Looks fine to me. Feel free to commit.
>
> Something we are still missing is showing the security dialog in the
> first place. With the patch, if a security dialog is shown, it will
> show a warning for unsigned jnlp files (if appropriate). But the
> security dialog wont be shown unless there is another problem. We need
> to make the security dialog come up even if the only problem is
> missing signed jnlp files.
>
> Cheers,
> Omair
Thanks for the review, Omair. I will look into prompting a security
dialog if a signed JNLP warning is to be displayed (but nothing has
triggered a security dialog prompt).
--
Cheers,
Saad Mohammad
More information about the distro-pkg-dev
mailing list