[icedtea-web] RFC: PR769: IcedTea-Web plugin does not work with some ssl sites with OpenJDK7

Omair Majid omajid at redhat.com
Tue Aug 23 10:06:32 PDT 2011


On 08/22/2011 04:23 PM, Deepak Bhole wrote:
> * Deepak Bhole<dbhole at redhat.com>  [2011-08-09 14:25]:
>> * Deepak Bhole<dbhole at redhat.com>  [2011-08-03 17:08]:
>>> Hi,
>>>
>>> Attached fix is for PR769:
>>> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=769
>>>
>>> The fix is not Java 7 specific ... Java 7 just exposed the bug.
>>>
>>
>> ping?
>>
>
> ping
>

Looks fine to me.

Just a thought, do you think it might be easier to read if the patch was 
modified to be like:

if (!isExplicitlyTrusted) {
   if (hostName == null) {
     CNMatched = false;
   } else {
     /* old code here */
   }
}

Anyway, okay to commit to all branches.

Cheers,
Omair



More information about the distro-pkg-dev mailing list