[RFC]: make IcedTea-web to be compatible with RHEL5 libraries

[Dr Andrew John Hughes]

On 11:51 Wed 31 Aug     , Jiri Vanek wrote:

snip...

> Hi!
> Quite nitpick isn't it? :) 

Yeah :-)  But may as well get it right first time.

> But I'm getting to like the patch.
> 
> Mostly cosmetic changes:
> Acinclude code shrunken to two lines
> IT_GET_GLIBVERSION rename top IT_CHECK_GLIB_VERSION
> GLIB214 renamed to LEGACY_GLIB.
> getFirtsTableInstance renamed to getFirstInTableInstance
> all #ifdef LEGACY_GLIB support functions moved to the block on the start of the file.
> 
> I have refactored getFirstInTableInstance function, so it do not need  "ifdef mozzila"  block (I hope) and is taking argument of GHashTable*, so it can work with any table. When called (on same places as before) it is called with instance_to_id_map parameter so it search in the same table as before. This approach seems much more clearer to  me  then before.
> 

Looks great now.  Thanks for all your hard work.  Approved.

[Only problem is you don't seem to have sent this to distro-pkg-dev.  Bringing the list back in on the loop.]
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37