[RFC][icedtea-web] Change icon for AccessWarningPane dialogs

Danesh Dadachanji ddadacha at redhat.com
Mon Dec 5 08:30:27 PST 2011



On 05/12/11 11:05 AM, Deepak Bhole wrote:
> * Omair Majid<omajid at redhat.com>  [2011-12-05 11:03]:
>> On 12/05/2011 10:59 AM, Danesh Dadachanji wrote:
>>> Hi,
>>>
>>> On 05/12/11 10:51 AM, Deepak Bhole wrote:
>>>>
>>>> Patch looks fine. Where is question.png btw? I'd like to take a look
>>>> before approving.
>>>>
>>>
>>> It's been in HEAD for a while, it's the same icon that appears when you
>>> verify a trusted cert. It's stored in
>>> icedtea-web/netx/net/sourceforge/jnlp/resources/
>>
>>
>> It's available online at:
>>
>> http://icedtea.classpath.org/hg/icedtea-web/raw-file/71f338e881d2/netx/net/sourceforge/jnlp/resources/question.png
>>
>
> Doh. Okay yes if it is in HEAD, okay for 1.0 and 1.1 too.
>

FWIW, the icon isn't in 1.0 or 1.1, it was added in a different 
changeset[1]. Not sure if I should be adding the png to this changeset 
or backporting the other changeset. It's been soaked by HEAD for a while 
now. I also think it might be a good idea since it affects user 
interaction with the plugin.

Pushing this to HEAD for now.

Regards,
Danesh

[1] http://icedtea.classpath.org/hg/icedtea-web/rev/61e08e67b176



More information about the distro-pkg-dev mailing list