RFC: backport S7102369

[Dr Andrew John Hughes]

On 17:46 Mon 12 Dec     , Omair Majid wrote:
> On 12/12/2011 05:41 PM, Dr Andrew John Hughes wrote:
> > On 14:04 Mon 12 Dec     , Omair Majid wrote:
> >> Hi,
> >>
> >> I would like to backport the fix for S7102369 to icedtea6.
> >>
> >> The fix is already in jdk6, but missed the jdk6b24 cutoff:
> >> http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/6b46f3c7c97c
> >>
> >> This fixes a regression caused by the recent security update that
> >> requires rmiregistry to be started with java.rmi.server.codebase
> >> property set. Additional details can be found in this bug report:
> >> https://bugzilla.redhat.com/show_bug.cgi?id=751203
> >>
> >> The patch for HEAD is attached. If no one has any objections, I will
> >> prepare patches for 1.9 and 1.10 as well.
> >>
> >> ChangeLog:
> >> 2011-12-12  Omair Majid<omajid at redhat.com>
> >>
> >>       S7102369, S7094468: remove java.rmi.server.codebase property
> >>       parsing from rmiregistry
> >>       * patches/openjdk/7102369-7094468-rmiregistry.patch: New file.
> >>       Backport from OpenJDK6.
> >>       * Makefile.am (ICEDTEA_PATCHES): Apply the patch.
> >>
> >> Any thoughts or comments?
> >>
> >
> > This one was on my own backport TODO list after it was posted to OpenJDK6,
> > so thanks for handling it.  I don't like that the patch includes a lot of
> > unnecessary changes to generics but as this is in the original OpenJDK6
> > patch, I guess we're stuck with it.
> >
> 
> I guess the developer who did the backport just wanted to sync the 
> openjdk6 and openjdk7 versions to avoid any surprises and to 
> (effectively) maintain one version of the code going forward.
> 

Still wrong to combine it into one patch IMHO.

> > Is there any reason you're not considering 1.8?  It's still supported at present.
> 
> Oh, right. I can make a patch for that too. Does the original patch look 
> okay for HEAD?
> 

Yes, it's just a simple backport and you don't need approval for HEAD.
I would suggest adding it there, then posting the backports in a week's time if no
issues arise.

> Thanks,
> Omair

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20111212/b31f01d6/attachment.bin