[PATCH] NP_GetMIMEDescription() returns const char*

[Dr Andrew John Hughes]

On 11:09 Mon 12 Dec     , Jon VanAlten wrote:
> Hi all,
> 
> ----- Original Message -----
> > From: "Omair Majid" <omajid at redhat.com>
> > To: "Thomas Meyer" <thomas at m3y3r.de>
> > Cc: "distro-pkg-dev" <distro-pkg-dev at openjdk.java.net>
> > Sent: Monday, December 12, 2011 10:26:18 AM
> > Subject: Re: [PATCH] NP_GetMIMEDescription() returns const char*
> > 
> > Hi Thomas,
> > 
> > On 12/10/2011 08:11 AM, Thomas Meyer wrote:
> > > # HG changeset patch
> > > # User Thomas Meyer<thomas at m3y3r.de>
> > > # Date 1323522372 -3600
> > > # Node ID 2b69ce95feb38023b2be8bec3bc87f2219d0c80b
> > > # Parent  3674bf4ef962a752a05bf7bfa5aee19a817c4834
> > >
> > > /usr/include/xulrunner-sdk-2/npfunctions.h defines "const char*
> > > NP_GetMIMEDescription(void);"
> > > make icedtea-web version also return a const char*
> > > This fix is needed to make icedtea-web compile on Fedora 16.
> > >
> > 
> > Thanks for the patch. This patch is already included in Fedora [1].
> > We
> > are aware of the issue [2], but there is so simple fix. If we apply
> > this
> > patch, it breaks icedtea-web builds on distributions using an older
> > version of xulrunner :(
> > 
> > Cheers,
> > Omair
> > 
> > [1]
> > http://pkgs.fedoraproject.org/gitweb/?p=icedtea-web.git;a=blob;f=icedtea-web-1.1.4-npapi-fix.patch;h=79ca0a6c009d310de5eb082d9ae5291da46e7dde;hb=refs/heads/f16
> > 
> > [2]
> > http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2011-November/016240.html
> > 
> 
> Seems to me that if this is a change that is expected to stay in
> xulrunner going forward, the preferred approach would be to make the
> change in icedtea-web and document the well-known fix for those
> building against older xulrunner, rather than the other way around.
> Just my $0.02.
> 
> cheers,
> jon

To me, it would seem appropriate to have this change in a new major release
(1.2, which seems to be overdue anyway) and retain the older support in the
1.0 and 1.1 series.

On that subject, how long do we intend to support the 1.0 series?
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20111212/049525ad/attachment.bin