[PATCH] getMember: Fix returned object type - v2

[Thomas Meyer]

Am Montag, den 12.12.2011, 10:30 -0500 schrieb Omair Majid:
> On 12/09/2011 01:10 PM, Thomas Meyer wrote:
> > Use createJavaObjectFromVariant() on NPVariant returned by
> > NPN_GetProperty() to
> > create the Java object. This should create the correct object return type.
> > See also bug report: https://bugzilla.redhat.com/show_bug.cgi?id=586194
> >
> 
> Thanks for the patch!
> 
> The change makes sense to me - and I am rather surprised it was not 
> already done that way. I would like Deepak (our plugin guru) to take a 
> look before we accept it, though. Let's see what he has to say about this.

Here is another fix on top of this patch:

# HG changeset patch
# User Thomas Meyer <thomas at m3y3r.de>
# Date 1323776736 -3600
# Node ID 7d090bfa381924100c0f8446dda2a615a75637d9
# Parent  2b69ce95feb38023b2be8bec3bc87f2219d0c80b
getMember: Fix response message

diff -r 2b69ce95feb3 -r 7d090bfa3819 plugin/icedteanp/IcedTeaPluginRequestProcessor.cc
--- a/plugin/icedteanp/IcedTeaPluginRequestProcessor.cc	Sat Dec 10 14:06:12 2011 +0100
+++ b/plugin/icedteanp/IcedTeaPluginRequestProcessor.cc	Tue Dec 13 12:45:36 2011 +0100
@@ -556,11 +556,11 @@
     createJavaObjectFromVariant(instance, *member_ptr, &result_id);
 
     IcedTeaPluginUtilities::constructMessagePrefix(0, reference, &response);
-    if (*(message_parts->at(2)) == "GetSlot")
+    if (*(message_parts->at(4)) == "GetSlot")
     {
+        response.append(" JavaScriptGetSlot ");
+    } else {
         response.append(" JavaScriptGetMember ");
-    } else {
-        response.append(" JavaScriptGetSlot ");
     }
     response.append(result_id.c_str());
     plugin_to_java_bus->post(response.c_str());



-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20111213/c79f44ce/attachment.bin