[Bug 835] New: javaws findBestUrl collects open connections

[bugzilla-daemon at icedtea.classpath.org]

http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=835

             Bug #: 835
           Summary: javaws findBestUrl collects open connections
    Classification: Unclassified
           Product: IcedTea-Web
           Version: unspecified
          Platform: x86_64
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: NetX
        AssignedTo: omajid at redhat.com
        ReportedBy: bldewolf at csupomona.edu
                CC: unassigned at icedtea.classpath.org


In icedtea-web-1.1.4, javaws doesn't close connections in the findBestUrl
method in ResourceTracker.java.  Normally this just means there's a couple
extra connections floating around (until gc?), but for mediocre webservers
(such as those on embedded devices) this can be crippling.

In my case, I believe that it is specifically the act of connecting and only
reading the response code causes the awful webserver to hang up responding to
anyone.  Once this is changed to disconnect after reading the code, the
webserver no longer hangs up.

Anyway, it's still just a good idea to clean up connections that are no longer
needed.  Here's a diff that does just that:

diff -ur
icedtea-web-1.1.4.orig/netx/net/sourceforge/jnlp/cache/ResourceTracker.java
icedtea-web-1.1.4/netx/net/sourceforge/jnlp/cache/ResourceTracker.java
--- icedtea-web-1.1.4.orig/netx/net/sourceforge/jnlp/cache/ResourceTracker.java
   2011-08-31 11:17:30.000000000 -0700
+++ icedtea-web-1.1.4/netx/net/sourceforge/jnlp/cache/ResourceTracker.java   
2011-12-14 12:30:28.000000000 -0800
@@ -859,6 +859,7 @@
                 if (connection instanceof HttpURLConnection) {
                     HttpURLConnection con = (HttpURLConnection)connection;
                     int responseCode = con.getResponseCode();
+                    ((HttpURLConnection) connection).disconnect();
                     if (responseCode == -1 || responseCode < 200 ||
responseCode >= 300) {
                         continue;
                     }

-- 
Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.