[RFC][icedtea-web] Patch to enable compilation of icedtea-web on both xulrunners apis

Danesh Dadachanji ddadacha at redhat.com
Mon Dec 19 10:48:35 PST 2011


Hi Jiri,

Been a bit too busy last week to review :/

On 15/12/11 05:42 AM, Jiri Vanek wrote:
> 2011-12-15 Jiri Vanek <jvanek at redhat.com>
>
> * acinclude.m4: added definition of IT_CHECK_XULLRUNNER_API_VERSION,
> which tryes to compile small program against new xulrunner api
> * configure.ac: added call of IT_CHECK_XULLRUNNER_API_VERSION
> * plugin/icedteanp/IcedTeaNPPlugin.cc: (NP_GetMIMEDescription)
> return type set-up by dependecy on defined LEGACY_XULRUNNERAPI.
> This one is seted by IT_CHECK_XULLRUNNER_API_VERSION during configure.
> if defined, then old char* is used. New const char* is used otherwise.

Some minor typos =)
s/XULLRUNNER/XULRUNNER
s/tryes/tries
s/seted/set

Apart from that and the indenting Deepak mentioned, everything looks 
good. Nice work!

Regards,
Danesh



More information about the distro-pkg-dev mailing list