[RFC][icedtea-web] made xsltproc to be checked mandatory tool, instead of ignore its failure

Danesh Dadachanji ddadacha at redhat.com
Mon Dec 19 11:39:26 PST 2011

Deepak: Changelog in the email? =)

Jiri: Comments inline.
On 19/12/11 11:47 AM, Deepak Bhole wrote:
> * Jiri Vanek<jvanek at redhat.com>  [2011-12-15 11:02]:
>> 2011-12-15  Jiri Vanek<jvanek at redhat.com>
>> 	* configure.ac: added search for xsltproc program and setting
>> 	WITH_CSLTPROC variable
>> 	* makefile.am: xsltproc result is no longer ignored, command
>> 	itself is in conditional block

ChangeLog indenting looks incorrect. Some (more) typos:

>>   	 cat stderr.log>&2
>> -	-xsltproc $(TESTS_SRCDIR)/$(REPORT_STYLES_DIRNAME)/jreport.xsl $(JNLP_TESTS_ENGINE_DIR)/tests-output.xml>  $(TESTS_DIR)/index_reproducers.html
>> +	$(XSLTPROC) $(TESTS_SRCDIR)/$(REPORT_STYLES_DIRNAME)/jreport.xsl $(JNLP_TESTS_ENGINE_DIR)/tests-output.xml>  $(TESTS_DIR)/index_reproducers.html
>> +endif

Perhaps for consistency's sake, there should be a ' ; \ ' at the end of 
the cat and $(XSLTPROC) lines (similar to the 'cat stdout...' line). I'm 
pretty sure that building won't make a difference but I've had 
experience where everything with the buildbot complaining and failing 
because of minor syntax. I doubt it will because it did not for the 
-xsltproc line but I don't see the harm in being more precise. =)

>> -	cat stderr.log>&2 ;
>> -	-xsltproc $(TESTS_SRCDIR)/$(REPORT_STYLES_DIRNAME)/jreport.xsl $(NETX_UNIT_TEST_DIR)/tests-output.xml>  $(TESTS_DIR)/index_unit.html
>> +	cat stderr.log>&2
>> +	$(XSLTPROC) $(TESTS_SRCDIR)/$(REPORT_STYLES_DIRNAME)/jreport.xsl $(NETX_UNIT_TEST_DIR)/tests-output.xml>  $(TESTS_DIR)/index_unit.html
>> +endif

Same as above.


More information about the distro-pkg-dev mailing list