[RFC][icedtea-web] Patch to enable compilation of icedtea-web on both xulrunners apis

[Jiri Vanek]

On 12/19/2011 05:43 PM, Deepak Bhole wrote:
> * Jiri Vanek<jvanek at redhat.com>  [2011-12-15 05:43]:
>> 2011-12-15  Jiri Vanek<jvanek at redhat.com>
>>
>> 	* acinclude.m4: added definition of IT_CHECK_XULLRUNNER_API_VERSION,
>> 	which tryes to compile small program against new xulrunner api
>> 	* configure.ac: added call of IT_CHECK_XULLRUNNER_API_VERSION
>> 	* plugin/icedteanp/IcedTeaNPPlugin.cc: (NP_GetMIMEDescription)
>> 	return type set-up by dependecy on defined LEGACY_XULRUNNERAPI.
>> 	 This one is seted by IT_CHECK_XULLRUNNER_API_VERSION during configure.
>> 	if defined, then old char* is used. New const char* is used otherwise.
>>
>>
>> cc: O:)
>>
>>
>
> Hi Jiri,
>
> Indentation looks all weird to me. Can you please re-indent and repost?
>
fixed. ok?
> Code itself looks fine to me.
>
> Thanks,
> Deepak
>

 >Some minor typos =)
 >s/XULLRUNNER/XULRUNNER
 >s/tryes/tries
 >s/seted/set
 >
 >Apart from that and the indenting Deepak mentioned, everything looks good. Nice work!
 >
 >Regards,
 >Danesh

fixed!


I also think this should go into 1.1, as it is run on f15, which is infected by xulrunner issue  too.

Kind Regards,
    J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: compilabeleWithBothXullrunnersAapi.patch
Type: text/x-patch
Size: 2367 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20111220/9d16f51a/compilabeleWithBothXullrunnersAapi.patch