[PATCH] getMember: Fix returned object type - v2

Deepak Bhole dbhole at redhat.com
Wed Dec 21 14:37:23 PST 2011


* Thomas Meyer <thomas at m3y3r.de> [2011-12-19 17:05]:
> Am Montag, den 12.12.2011, 10:30 -0500 schrieb Omair Majid:
> > On 12/09/2011 01:10 PM, Thomas Meyer wrote:
> > > Use createJavaObjectFromVariant() on NPVariant returned by
> > > NPN_GetProperty() to
> > > create the Java object. This should create the correct object return type.
> > > See also bug report: https://bugzilla.redhat.com/show_bug.cgi?id=586194
> > >
> > 
> > Thanks for the patch!
> > 
> > The change makes sense to me - and I am rather surprised it was not 
> > already done that way. I would like Deepak (our plugin guru) to take a 
> > look before we accept it, though. Let's see what he has to say about this.
> 
> Hi,
> 
> any news on this?
> 

Thomas, thank you very much for the patch.

I have looked through it and tried it out. I see no issues with it and
have committed it to HEAD, 1.0 and 1.1:
http://icedtea.classpath.org/hg/icedtea-web/rev/42c3ed21e228
http://icedtea.classpath.org/hg/release/icedtea-web-1.0/rev/71327f4cb706
http://icedtea.classpath.org/hg/release/icedtea-web-1.1/rev/cdd0bbf399e8

Thanks again!

Cheers,
Deepak



More information about the distro-pkg-dev mailing list