[PATCH] getMember: Fix returned object type - v2

Deepak Bhole dbhole at redhat.com
Thu Dec 22 13:20:25 PST 2011


* Thomas Meyer <thomas at m3y3r.de> [2011-12-22 03:24]:
> 
> Zitat von Deepak Bhole <dbhole at redhat.com>:
> 
> >Thomas, thank you very much for the patch.
> 
> My pleasure. Thanks for inclusion of the patch.
> 
> I did post another small patch on top of this one, that fixes the
> response message send to the java part of the plugin:
> 
> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2011-December/016465.html
>

Doh, I missed that one. I see no issues with that one either. Looks like
the issue went un-noticed because the Java side does not care about the
return tag, only the reference key when it is waiting for a reply.

Thanks for the second patch as well. Applied to all branches.

Cheers,
Deepak
 
> would you please have a look at this, too? I think currently
> "JavaScriptGetSlot" is returned, but "JavaScriptGetMember" should be
> the return value, but this seems to be more of a cosmetic nature as
> the sendMember function seems to work also with a
> "JavaScriptGetSlot" in the repsond message.
> 
> kind regards
> thomas
> 
> 
> 



More information about the distro-pkg-dev mailing list