CubicCurve2D backports - review

[Pavel Tisnovsky]

Hi Denis,

looks ok for me.

I just have one question - is there any regression test for checking old
and new way for calculating quad curves?

I mean tests mainly for these issues:
S4493128: CubicCurve2D intersects method fails
S4724552: CubicCurve2D.contains(Rectangle2D) returns true when only
partially contained.
S4645692: solveCubic does not return all solutions.


Cheers,
Pavel

Denis Lila wrote:
> Hi.
> 
> I'd like to backport the three attached patches.
> 
> 
> hg diff:
> 
> diff -r cd6310f10fab ChangeLog
> --- a/ChangeLog	Sun Jan 30 00:45:18 2011 +0000
> +++ b/ChangeLog	Mon Jan 31 13:28:19 2011 -0500
> @@ -1,3 +1,11 @@
> +2011-01-31  Denis Lila <dlila at redhat.com>
> +
> +	* NEWS: Update with the 3 backports
> +	* Makefile.am (ICEDTEA_PATCHES): Add the patches
> +	* patches/openjdk/4493128-CubicCurve2D.patch: New file.
> +	* patches/openjdk/4645692-CubicCurve2D.solveCubic.patch: Likewise.
> +	* patches/openjdk/4724552-CubicCurve2D.patch: Likewise.
> +
>  2011-01-29  Andrew John Hughes  <ahughes at redhat.com>
>  
>  	* patches/gcc-suffix.patch,
> diff -r cd6310f10fab Makefile.am
> --- a/Makefile.am	Sun Jan 30 00:45:18 2011 +0000
> +++ b/Makefile.am	Mon Jan 31 13:28:19 2011 -0500
> @@ -275,7 +275,10 @@
>  	patches/jtreg-international-fonts-styles.patch \
>  	patches/openjdk/6736649-text_bearings.patch \
>  	patches/openjdk/6797139-jbutton_truncation.patch \
> -	patches/openjdk/6883341-text_bearing_exception.patch
> +	patches/openjdk/6883341-text_bearing_exception.patch \
> +	patches/openjdk/4724552-CubicCurve2D.patch \
> +	patches/openjdk/4493128-CubicCurve2D.patch \
> +	patches/openjdk/4645692-CubicCurve2D.solveCubic.patch
>  
>  if !WITH_ALT_HSBUILD
>  ICEDTEA_PATCHES += \
> diff -r cd6310f10fab NEWS
> --- a/NEWS	Sun Jan 30 00:45:18 2011 +0000
> +++ b/NEWS	Mon Jan 31 13:28:19 2011 -0500
> @@ -403,6 +403,9 @@
>    - S6736649: test/closed/javax/swing/JMenuItem/6458123/ManualBug6458123.java fails on Linux
>    - S6797139: JButton title is truncating for some strings irrespective of preferred size.
>    - S6883341: SWAT: jdk7-b72 swat build(2009-09-17) threw exceptions when running Java2D demo by clicking Paint ta
> +  - S4493128: CubicCurve2D intersects method fails
> +  - S4724552: CubicCurve2D.contains(Rectangle2D) returns true when only partially contained.
> +  - S4645692: solveCubic does not return all solutions.
>  * Bug fixes
>    - RH647157, RH582455: Update fontconfig files for rhel 6
>    - RH661505: JPEGs with sRGB IEC61966-2.1 color profiles have wrong colors
> 
> ...(and here should be the diff of the patches, but those are attached).
> 
> Thank you,
> Denis.
>