[icedtea-web] RFC: make browser proxy less noisy

[Andrew John Hughes]

On Fri, Feb 04, 2011 at 08:51:11AM +0100, Deepak Bhole wrote:
> * Omair Majid <omajid at redhat.com> [2011-02-04 08:37]:
> > Hi,
> > 
> > The attached patch makes netx's firefox integration print fewer
> > messages on stdout/err. The messages refer to missing things that
> > were not implemented before, so not informing the user about it isnt
> > a regression.
> > 
> > Thoughts?
> > 
> 
> Most users probably won't know what it means and it might alarm them
> unnecessarily. It is probably best to keep it silent.
> 
> Patch looks good to me, okay for HEAD after adding ChangeLog entry.
> 

How is debug mode turned on?  Is this an option to NetX?

> Thanks,
> Deepak
> 
> > Cheers,
> > Omair
> 
> > diff -r 97f40ebebbdf netx/net/sourceforge/jnlp/browser/BrowserAwareProxySelector.java
> > --- a/netx/net/sourceforge/jnlp/browser/BrowserAwareProxySelector.java	Tue Feb 01 10:53:44 2011 -0500
> > +++ b/netx/net/sourceforge/jnlp/browser/BrowserAwareProxySelector.java	Fri Feb 04 02:28:17 2011 -0500
> > @@ -120,7 +120,10 @@
> >          }
> >  
> >          try {
> > -            browserAutoConfigUrl = new URL(prefs.get("network.proxy.autoconfig_url"));
> > +            String url = prefs.get("network.proxy.autoconfig_url");
> > +            if (url != null) {
> > +                browserAutoConfigUrl = new URL(url);
> > +            }
> >          } catch (MalformedURLException e) {
> >              e.printStackTrace();
> >          }
> > @@ -195,7 +198,9 @@
> >                  if (optionDescription == null) {
> >                      optionDescription = "Unknown";
> >                  }
> > -                System.err.println(R("RProxyFirefoxOptionNotImplemented", browserProxyType, optionDescription));
> > +                if (JNLPRuntime.isDebug()) {
> > +                    System.err.println(R("RProxyFirefoxOptionNotImplemented", browserProxyType, optionDescription));
> > +                }
> >                  proxies.add(Proxy.NO_PROXY);
> >          }
> >  
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37