[icedtea-web] RFC: fix bug in proxy settings in control panel

[Andrew Su]

----- Original Message -----
> From: "Deepak Bhole" <dbhole at redhat.com>
> To: "Omair Majid" <omajid at redhat.com>
> Cc: "IcedTea" <distro-pkg-dev at openjdk.java.net>
> Sent: Tuesday, February 8, 2011 7:46:04 PM
> Subject: Re: [icedtea-web] RFC: fix bug in proxy settings in control panel
> * Omair Majid <omajid at redhat.com> [2011-02-08 19:20]:
> > Hi,
> >
> > The attached fixes a bug in control panel. The bug makes the control
> > panel lose part of the proxy address when "Advanced..." is clicked.
> >
> > Ok to commit?
> >
> 
> ChangeLog is missing. OK for commit to HEAD and 1.0 after that.
Hi,

1.0 doesn't use DocumentAdapter. So it should be in HEAD only.

Cheers,
 Andrew

> 
> > diff -r 2d39fa58036e
> > netx/net/sourceforge/jnlp/controlpanel/NetworkSettingsPanel.java
> > ---
> > a/netx/net/sourceforge/jnlp/controlpanel/NetworkSettingsPanel.java
> > Tue Feb 01 21:07:03 2011 -0500
> > +++
> > b/netx/net/sourceforge/jnlp/controlpanel/NetworkSettingsPanel.java
> > Sat Feb 05 20:03:20 2011 -0500
> > @@ -114,7 +114,7 @@
> >          addressField.getDocument().addDocumentListener(new
> >          DocumentAdapter(config, properties[1]));
> >
> >          final JTextField portField = new
> >          JTextField(config.getProperty(properties[2]), 3);
> > - portField.getDocument().addDocumentListener(new
> > DocumentAdapter(config, properties[1]));
> > + portField.getDocument().addDocumentListener(new
> > DocumentAdapter(config, properties[2]));
> >
> >          // Create the button which allows setting of other types of
> >          proxy.
> >          JButton advancedProxyButton = new
> >          JButton(Translator.R("NSAdvanced") + "...");