[icedtea-web] Couple of minor enhancement patches

[Deepak Bhole]

* Omair Majid <omajid at redhat.com> [2011-02-09 18:52]:
> On 02/09/2011 06:25 PM, Deepak Bhole wrote:
> >Hi,
> >
> >I would like to add these patches to 1.0 and HEAD. Any objections?
> >
> >The package access one restricts access to net.sourceforge.jnlp.*
> >classes as a pre-emptive measure to thwart potential security issues. I
> >tested it with various JNLP services and found no issues.
> >
> >ChangeLog:
> >
> >* netx/net/sourceforge/jnlp/runtime/JNLPRuntime.java (initialize):
> >   Restrict access to net.sourceforge.jnlp.* classes by untrusted
> >   classes.
> >
> 
> This looks fine to me.
> 
> >
> >The latter adds an encoding entry to the desktop files.
> >ChangeLog:
> >
> >* itweb-settings.desktop.in: Added UTF-8 encoding for the file.
> >* javaws.desktop.in: Same.
> >
> 
> Is there a reason for adding this patch? The Encoding key was
> deprecated in the Desktop Entry Specification 0.9.4 [1] (which was
> released in 2006).
> 
> $ desktop-file-validate javaws.desktop
> javaws.desktop: warning: key "Encoding" in group "Desktop Entry" is
> deprecated
>

Weird. I added it because one of the (rpmlint like) tools I used here
complained that Encoding was missing.

Given that the upstream standard has deprecated it, I agree, we should
not add it either.

Thanks!
Deepak

> Thanks,
> Omair
> 
> [1] http://cgit.freedesktop.org/xdg/xdg-specs/commit/?id=6855384d021d88557f80674798c584c15b547f36