[icedtea-web] RFC: fix 2 issues in fix for versioned/packed jars
Omair Majid
omajid at redhat.com
Fri Feb 11 07:20:05 PST 2011
On 02/11/2011 08:49 AM, Dr Andrew John Hughes wrote:
> On 19:20 Thu 10 Feb , Omair Majid wrote:
>> Hi,
>>
>> The attached patch fixes 2 issues in my previous patch for adding
>> packed/versioned jar support.
>>
>> The first patch fixes names so that all methods that relate to
>> ResourcesDesc are actually named *ResourcesDesc* instead of
>> *ResourceDesc* (s at end of resources).
>>
>
> But why?
So the method name (getResourcesDescs) properly reflects the type
returned (ResourcesDesc[]).
>
>> The second fix implements the new method getResourcesDescs in
>> PluginBridge - the version in JNLPFile causes a NullPointerException
>> for plugins.
>>
>
> Ok. Please commit the two as separate patches.
>
Will do. Thanks for looking over the patches.
Cheers,
Omair
More information about the distro-pkg-dev
mailing list