[icedtea-web] RFC: move TimedHashMap to netx

[Omair Majid]

On 02/14/2011 05:42 PM, Dr Andrew John Hughes wrote:
> On 16:33 Mon 14 Feb     , Omair Majid wrote:
>> Hi,
>>
>> The attached patch moves TimeHashMap from
>> plugin/icedteanp/java/sun/applet/PluginProxySelector.java to
>> netx/net/sourceforge/jnlp/util/TimedHashMap.java, so other
>> ProxySelectors can also use it. My patch for adding proxy auto config
>> support will be using this new class.
>>
>> Other than the movement, there are a few minor changes to it:
>> - It no longer extends HashMap. TimedHashMap did not override all the
>>     HashMap methods and it was possible to see inconsistent data. By
>>     reducing the interface, this should not be a problem any more (the
>>     plugin code still compiles fine).
>> - The use of Date has been replaced by System.nanoTime(). This should
>>     give us a more monotonic clock and be less susceptible to clock
>>     changes (especially to moving the clock backwards).
>>
>> Any thoughts or concerns?
>>
>
> Could you do the move in a separate patch to the other changes?
> Otherwise, the changes are unclear as the file appears new.
>

Good point. I have split it into two patches. part1 contains all the 
changes necessary to move TimedHashMap and make it compile (including 
the PluginDebug changes). part2 contains the actual changes in 
TimedHashMap (not extending HashMap and using System.nanoTime()).

Any other comments?

Cheers,
Omair
-------------- next part --------------
A non-text attachment was scrubbed...
Name: timedhashmap-02-part2.patch
Type: text/x-patch
Size: 2699 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110214/8d86107c/timedhashmap-02-part2.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: timedhashmap-02-part1.patch
Type: text/x-patch
Size: 6556 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110214/8d86107c/timedhashmap-02-part1.patch