FYI: Fix PR632: patches/security/20110215/6878713.patch breaks shark zero build

[Dr Andrew John Hughes]

On 22:50 Wed 16 Feb     , Mark Wielaard wrote:
> On Wed, 2011-02-16 at 21:47 +0000, Dr Andrew John Hughes wrote:
> > On 22:28 Wed 16 Feb     , Mark Wielaard wrote:
> > > 2011-02-16  Xerxes Ranby  <xerxes at zafena.se>
> > >             Mark Wielaard  <mark at klomp.org>
> > > 
> > >     PR632: 6878713.patch breaks shark zero build
> > >     * patches/icedtea-stdc-limit-macros.patch
> > >     (openjdk/hotspot/src/share/vm/utilities/globalDefinitions_gcc.hpp):
> > >     Only define __STDC_LIMIT_MACROS if undefined.
> > >     * Makefile.am (ICEDTEA_PATCHES): Add new patch.
> > >     * NEWS: Updated.
> > > 
> > Did you test this with both versions of HotSpot?
> 
> No, but I don't see how it would fail, the patch is right after the
> patch that broke it. It is currently going through all the buildbot
> builders. If you have configurations you want to have regularly tested
> please setup a buildslave for it.
> 
> Thanks,
> 
> Mark
> 

Please test HotSpot patches with both available HotSpot builds to avoid
breakage.

Also, if you had posted this patch for review instead of just committing
it, I would have pointed out that:

* It might be better to only apply it for Shark/Zero builds to reduce breakage.
Other configurations are not broken.
* We no longer use the 'icedtea-' prefix.

I'd prefer not to have yet more work on my plate because people don't do full
testing of patches and commit them without any review.

Thanks,
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37