RFC: PR600 HS19 upgrade broke CACAO build on ARM

[Dr Andrew John Hughes]

On 12:20 Fri 18 Feb     , Xerxes Rånby wrote:
> When building icedtea6 with --enable-cacao  on ARM then the build break with the error message:
> 
> make[7]: *** No rule to make target `../../../../src/solaris/bin/arm/jvm.cfg', needed by `/var/lib/buildbot/icedtea/icedtea6-natty-armv7l-quick-cacao/build/openjdk.build/lib/arm/jvm.cfg'.  Stop.
> 
> The CACAO maintainer Stefan Ring have found out that it are possible to build CACAO on ARM if
> ICEDTEA_ZERO_BUILD gets sets to true.
> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=600
> 
> The attached patch unbreaks CACAO on ARM builds.
> Ok to push?
> 

No.  I think it should be fixed correctly, not just by enabling the zero build.
Do you know if this is because something we do in IcedTea for zero? Or something in OpenJDK?

> Cheers
> Xerxes
> 
> # HG changeset patch
> # User Stefan Ring <stefan at complang.tuwien.ac.at>
> # Node ID 2b0dfc2c88db1bea882b467ed5b5d274a8759c87
> # Parent 34511f89bc1da242067b23962cff081d2e94c74a
> PR600: Repair CACAO/ARM build.
> 
> 2011-02-17  Stefan Ring <stefan at complang.tuwien.ac.at>
> 
> 	* Makefile.am: Set ZERO_BUILD for CACAO as well.
> 
> diff --git a/Makefile.am b/Makefile.am
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -401,8 +401,12 @@
>  if ZERO_BUILD
>    ICEDTEA_ZERO_BUILD = true
>  else
> +if WITH_CACAO
> +  ICEDTEA_ZERO_BUILD = true
> +else
>    ICEDTEA_ZERO_BUILD =
>  endif
> +endif
>  if SHARK_BUILD
>    ICEDTEA_SHARK_BUILD = true
>  else
> 
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37