RFC: PR600 HS19 upgrade broke CACAO build on ARM

[Xerxes Rånby]

On 2011-02-18 15:25, Gary Benson wrote:
> Dr Andrew John Hughes wrote:
>> On 12:20 Fri 18 Feb     , Xerxes Rånby wrote:
>>> When building icedtea6 with --enable-cacao  on ARM then the build break with the error message:
>>>
>>> make[7]: *** No rule to make target `../../../../src/solaris/bin/arm/jvm.cfg', needed by `/var/lib/buildbot/icedtea/icedtea6-natty-armv7l-quick-cacao/build/openjdk.build/lib/arm/jvm.cfg'.  Stop.
>>>
>>> The CACAO maintainer Stefan Ring have found out that it are
>>> possible to build CACAO on ARM if ICEDTEA_ZERO_BUILD gets sets
>>> to true.
>>> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=600
>>>
>>> The attached patch unbreaks CACAO on ARM builds.
>>> Ok to push?
>> No.  I think it should be fixed correctly, not just by enabling
>> the zero build.  Do you know if this is because something we do
>> in IcedTea for zero? Or something in OpenJDK?
> You need to create the file jdk/src/solaris/bin/arm/jvm.cfg before
> building.  The other platforms (zero included) have their own files
> there.  Setting ZERO_BUILD=true enables some logic that causes the
> file to be copied from jdk/src/solaris/bin/zero/jvm.cfg rather than
> jdk/src/solaris/bin/$(ARCH)/jvm.cfg.
>
> Cheers,
> Gary
>
Thanks a lot Gary for pointing this missing file out and also thank you Andrew for the review!
I have attached a new patch that simply creates the missing openjdk/jdk/src/solaris/bin/arm/jvm.cfg if BUILD_CACAO are defined.

Ok to push?

Cheers,
Xerxes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr600.patch
Type: text/x-patch
Size: 3904 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110218/6ba50ded/pr600.patch