RFC: PR600 HS19 upgrade broke CACAO build on ARM

[Xerxes Ranby]

On 2011-02-19 01:08, Dr Andrew John Hughes wrote:
> On 16:11 Fri 18 Feb     , Xerxes Rånby wrote:
>    
>> On 2011-02-18 15:25, Gary Benson wrote:
>>      
>>> Dr Andrew John Hughes wrote:
>>>        
>>>> On 12:20 Fri 18 Feb     , Xerxes Rånby wrote:
>>>>          
>>>>> When building icedtea6 with --enable-cacao  on ARM then the build break with the error message:
>>>>>
>>>>> make[7]: *** No rule to make target `../../../../src/solaris/bin/arm/jvm.cfg', needed by `/var/lib/buildbot/icedtea/icedtea6-natty-armv7l-quick-cacao/build/openjdk.build/lib/arm/jvm.cfg'.  Stop.
>>>>>
>>>>> The CACAO maintainer Stefan Ring have found out that it are
>>>>> possible to build CACAO on ARM if ICEDTEA_ZERO_BUILD gets sets
>>>>> to true.
>>>>> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=600
>>>>>
>>>>> The attached patch unbreaks CACAO on ARM builds.
>>>>> Ok to push?
>>>>>            
>>>> No.  I think it should be fixed correctly, not just by enabling
>>>> the zero build.  Do you know if this is because something we do
>>>> in IcedTea for zero? Or something in OpenJDK?
>>>>          
>>> You need to create the file jdk/src/solaris/bin/arm/jvm.cfg before
>>> building.  The other platforms (zero included) have their own files
>>> there.  Setting ZERO_BUILD=true enables some logic that causes the
>>> file to be copied from jdk/src/solaris/bin/zero/jvm.cfg rather than
>>> jdk/src/solaris/bin/$(ARCH)/jvm.cfg.
>>>
>>> Cheers,
>>> Gary
>>>
>>>        
>> Thanks a lot Gary for pointing this missing file out and also thank you Andrew for the review!
>> I have attached a new patch that simply creates the missing openjdk/jdk/src/solaris/bin/arm/jvm.cfg if BUILD_CACAO are defined.
>>
>> Ok to push?
>>
>>      
> Ok by me.  Out of interest, do you know if hs20 now also works?
>
>    
Yes ARM + CACAO + hs20 with the pr600.patch also works!

I have verified it on my armv7l squeeze babbage system.

hg clone -r icedtea6http://icedtea.classpath.org/hg/icedtea6  <http://icedtea.classpath.org/hg/release/icedtea6-1.9>
mkdir icedtea6-cacao
cd icedtea6
quilt import pr600.patch
quilt push
./autogen.sh
cd ../icedtea6-cacao
../icedtea6/configure --enable-cacao --disable-bootstrap --disable-docs --with-hotspot-build=hs20
make

... 180 minutes later
xranby at babbage:/wd/icedtea6-cacao$ ./openjdk.build/j2sdk-image/bin/java -version
java version "1.6.0_21"
IcedTea Runtime Environment (1.10pre+r70ea35e42b14) (Debian build 1.6.0_21-b21)
CACAO (build 1.1.0pre2, compiled mode)

Cheers
Xerxes


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110220/443a6b5c/attachment.html