FYI: Fix PR632: patches/security/20110215/6878713.patch breaks shark zero build

[Mark Wielaard]

On Mon, 2011-02-21 at 20:52 +0000, Dr Andrew John Hughes wrote:
> I can see how it would be advantageous from a speed perspective, but for me,
> if I'm going to bother building one of the alternative VMs, I want to know it
> actually works.  Now I guess you can run 'check-hotspot' with each of the alternative
> VMs but I don't see why that saves anything over just doing the full build,
> which tests the VM heavily with lots of javac invocations.

So we need targets for at least check-hotspot and check-langtools to be
run with alternative runtimes build in. This might even be a nice idea
for pure hotspot client/server/tiered testing. Ideally also
make-check-jdk, but that on itself takes ages.

> > Also, could we have an alias for "hotspot=next" or something? Assuming
> > that we only support "current" and "next" hotspot, then you don't have
> > to remember which particular version it represents (also easier for
> > making sure a buildslave tracks them).
> > 
> 
> I think what you want is already catered for; as documented in README,
> a simple --with-hotspot-build will get you the alternative HotSpot.
> 
>   ORIGINAL_BUILD="original"
>   ALTERNATE_BUILD="hs20"
> ...
>    if test "x${HSBUILD}" = xyes; then
>         HSBUILD="${ALTERNATE_BUILD}"
>   elif test "x${HSBUILD}" = xno; then
>         HSBUILD="${ORIGINAL_BUILD}"
>   fi
> 
> so the two alternatives are always available via --with-hotspot-build
> and --without-hotspot-build, the former being the one from the HotSpot
> tarball, the latter from the original OpenJDK tarball.

O wow. That is nice. Completely missed that. I added a new "quick"
squeeze-x86_64 builder icedtea6-squeeze-x86_64-quick-hotspot for that
(patch attached - note the horrible copy/paste, sorry about that).

I would almost suggest you make this so that it is possible to use this
with --enable-additional-vms for easy testing by users...

Cheers,

Mark
-------------- next part --------------
A non-text attachment was scrubbed...
Name: icedtea6-squeeze-x86_64-quick-hotspot.patch
Type: text/x-patch
Size: 3076 bytes
Desc: 
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110222/391e1b35/icedtea6-squeeze-x86_64-quick-hotspot.patch