[icedtea-web] RFC: fix lookup of about.jnlp

[Deepak Bhole]

* Omair Majid <omajid at redhat.com> [2011-02-22 14:27]:
> On 02/22/2011 02:18 PM, Deepak Bhole wrote:
> >* Omair Majid<omajid at redhat.com>  [2011-02-22 14:15]:
> >>Hi,
> >>
> >>The fix to isolate icedtea-web in a non-JDK directory has resulted
> >>in javaws -about being broken. This is because javaws still looks
> >>for about.jnlp in the JDK directory. The attached patch fixes it by
> >>making netx use the about.jnlp that's included in netx.jar.
> >>
> >>I am not sure if this is the best fix; IcedTea-Web installs a
> >>separate about.jnlp in $(datadir)/icedtea-web/ which should be used
> >>instead.
> >>
> >>Ok to commit?
> >>
> >
> >Since we are using an in-jar jnlp, how does this affect lookup of
> >about.jar?
> >
> 
> The version of about.jnlp in the jar should be identical to the copy
> installed at $(datadir)/icedtea-web/.
> 
> You might also want to refer to a recent thread [1] where various
> issues in javaws -about are pointed out, including the fact that
> about.jar is completely unused right now. The about.jnlp file
> indicates that the canonical copies of about.jnlp and about.jar are
> stored on the icedtea servers [2]; javaws uses _those_ files rather
> than the on-disk copies.
> 
> Jiri has indicated interest in fixing these issues. This patch is
> more of a quick hack just to keep the existing system (even though
> it's far from perfect) working.
>

Ah okay. Fair enough. Patch looks fine to me. Assuming you have tested
this, OK for head and 1.0.

Cheers,
Deepak
 
> Cheers,
> Omair
> 
> [1] http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2011-February/012131.html
> [2] http://icedtea.classpath.org/netx/