[icedtea-web] RFC: PR638

[Deepak Bhole]

* Omair Majid <omajid at redhat.com> [2011-02-22 19:00]:
> Hi,
> 
> The attached patch fixes PR638. loadClass now throws a
> ClassNotFoundException instead of returning a null Class.
> 
> Okay to commit?
> 

Yep, it should have been doing that to begin with. Please apply this to
1.0 as well, as this is really expected behaviour..

OK for HEAD and 1.0

Cheers,
Deepak

> Cheers,
> Omair

> diff -r d245772c7043 AUTHORS
> --- a/AUTHORS	Tue Feb 22 15:11:31 2011 -0500
> +++ b/AUTHORS	Tue Feb 22 18:57:06 2011 -0500
> @@ -4,6 +4,7 @@
>  Lillian Angel <langel at redhat.com>
>  Deepak Bhole <dbhole at redhat.com>
>  Thomas Fitzsimmons <fitzsim at redhat.com>
> +Mark Greenwood <mark at dcs.shef.ac.uk>
>  Andrew John Hughes <gnu_andrew at member.fsf.org, ahughes at redhat.com>
>  Matthias Klose <doko at ubuntu.com>
>  Francis Kung <fkung at redhat.com>
> diff -r d245772c7043 ChangeLog
> --- a/ChangeLog	Tue Feb 22 15:11:31 2011 -0500
> +++ b/ChangeLog	Tue Feb 22 18:57:06 2011 -0500
> @@ -1,3 +1,10 @@
> +2011-02-22  Omair Majid  <omajid at redhat.com>
> +            Mark Greenwood <mark at dcs.shef.ac.uk>
> +
> +	* netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java (loadClass): Throw
> +	ClassNotFoundException instead of returning null.
> +	* AUTHORS: Update.
> +
>  2011-02-22  Omair Majid  <omajid at redhat.com>
>  
>  	* Makefile.am (uninstall-local): Fix typo in PACKAGE_NAME.
> diff -r d245772c7043 NEWS
> --- a/NEWS	Tue Feb 22 15:11:31 2011 -0500
> +++ b/NEWS	Tue Feb 22 18:57:06 2011 -0500
> @@ -14,6 +14,8 @@
>    - RH677332, CVE-2011-0706: IcedTea multiple signers privilege escalation
>  * New Features
>    - IcedTea-Web now installs to a FHS-compliant location
> +* Common Fixes and Improvements
> +  - PR638: JNLPClassLoader.loadClass(String name) can return null
>  * NetX
>    - Use Firefox's proxy settings if possible
>    - RH669942: javaws fails to download version/packed files (missing support for jnlp.packEnabled and jnlp.versionEnabled)
> diff -r d245772c7043 netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java
> --- a/netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java	Tue Feb 22 15:11:31 2011 -0500
> +++ b/netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java	Tue Feb 22 18:57:06 2011 -0500
> @@ -1045,6 +1045,10 @@
>                  }
>              }
>  
> +        if (result == null) {
> +            throw new ClassNotFoundException(name);
> +        }
> +
>          return result;
>      }
>