RFC: JamVM - Taste the New Flavour! --with-jamvm-src-zip option

[Xerxes Rånby]

On 2011-02-22 02:48, Xerxes Rånby wrote:
> On 2011-02-21 22:40, Robert Lougher wrote:
>> Hi,
>>
>> On 21 February 2011 21:22, Dr Andrew John Hughes<ahughes at redhat.com>
>> wrote:
>>> On 21:20 Sat 19 Feb , Xerxes Ranby wrote:
>>>> Greetings!
>>>>
>>>> "JamVM's got a shiny new Git repository, which contains the port to the
>>>> OpenJDK class-library."
>>>> http://draenog.blogspot.com/2011/02/openjdkjamvm-git-repository.html
>>>>
>>>> The attached patch adds Robert Lougher's new JamVM flavour to Icedtea6!

>>>> +stamps/download-jamvm.stamp:
>>>> +if BUILD_JAMVM
>>>> + if ! echo "$(JAMVM_SHA256SUM) $(JAMVM_SRC_ZIP)" \
>>>> + | $(SHA256SUM) --check ; \
>>>> + then \
>>>> + if [ $(JAMVM_SRC_ZIP) ] ; \
>>>> + then \
>>>> + mv $(JAMVM_SRC_ZIP) $(JAMVM_SRC_ZIP).old ; \
>>>> + fi ; \
>>>> + $(WGET) $(JAMVM_URL) -O $(JAMVM_SRC_ZIP); \
>>>> + if ! echo "$(JAMVM_SHA256SUM) $(JAMVM_SRC_ZIP)" \
>>>> + | $(SHA256SUM) --check ; \
>>>> + then echo "ERROR: Bad download of JamVM zip"; false; \
>>>> + fi; \
>>>> + fi
>>>> +endif
>>>> + mkdir -p stamps
>>>> + touch $@
>>>
>>> We need an option equivalent to --with-cacao-src-zip. I'd suggest
>>> adding this in a follow up patch. As with the drop tarballs, we
>>> should verify the checksum for pre-provided tarballs as well as
>>> download ones. It should be just a matter of symlinking the tarball
>>> here if an alternate one is specified.
>>>
>
> Noted, I will add --with-cacao-src-zip in another follow up patch.
>

Hi again!

I have attached the follow up patch to implement the new
--with-jamvm-src-zip option.

with-jamvm-src-zip.23feb.patch

Ok to push?
Cheers
Xerxes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: with-jamvm-src-zip.23feb.patch
Type: text/x-patch
Size: 3157 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110223/888b9b7d/with-jamvm-src-zip.23feb.patch