RFC: Always apply PR600 patch

[Xerxes Rånby]

On 2011-02-23 20:41, Dr Andrew John Hughes wrote:
> As discussed on IRC:
>
> <xranby-home>  gnu_andrew: is there a easy way to apply the patches/cacao/arm-jvm.cfg-pr600.patch for both CACAO and JAMVM builds?
> <xranby-home>  is it possible to write in Makefile.am    if CACAO_BUILD || JAMVM_BUILD \ ICEDTEA_PATCHES += \ atches/cacao/arm-jvm.cfg-pr600.patch
> <xranby-home>  ?
> <xranby-home>  the easiest way are to unconditionally apply the patch for all builds
> <gnu_andrew>  xranby-home, yeah I was just thinking that
> <gnu_andrew>  xranby-home, but will it hurt zero builds?
> <gnu_andrew>  or shark?
> <xranby-home>  no zero and shark jave its jvm.cfg in the zero dir
> <xranby-home>  have
> <xranby-home>  so i think they will be fine
> <gnu_andrew>  xranby-home, then I see no problem just applying it always
> <gnu_andrew>  xranby-home, and gets more testing then anyway
> <xranby-home>  gnu_andrew: im not in a possition to commit any patches since i am 30kilometers from my commit keys ;)
> <xranby-home>  but i can review a patch if you make one
> <gnu_andrew>  xranby-home, haha ok hang on
>
> Moving the PR600 patch to the main set of IcedTea patches allows the patch to cover both JamVM and CACAO,
> and also means it's application is tested by everyone's builds.
>
> ChangeLog:
>
> 2011-02-23  Andrew John Hughes<ahughes at redhat.com>
>
> 	* Makefile.am:
> 	Move PR600 patch to main patch set (so it
> 	is always applied) to cover both JamVM and
> 	CACAO.
>
> Ok Xerces?

It would be nice to move the arm-jvm.cfg-pr600.patch itself from the
patch/cacao to the patch directory.

Apart from that, the patch looks fine to me. Thanks for changing this!
+1

In the future we will hit this bug again for mips and s390 when using 
--enable-cacao or --enable-jamvm .

The architectures that currently are immune to this bug are
amd64 i586 sparc zero ia64 sparcv9 since they got a jvm.cfg preinstalled 
in the openjdk/jdk/src/solaris/bin directory.

Cheers
Xerxes